Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PopED + babelmixr2 for windows #79

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mattfidler
Copy link
Contributor

Hi @andrewhooker

This allows windows based PopED models from babelmixr2 to be run in parallel without modifying any user code. This mean the same user code works on windows and linux/mac

This requires the following pull request for babelmixr2:

nlmixr2/babelmixr2#141

@mattfidler
Copy link
Contributor Author

In general it saves the babelmixr2 environment inside of the poped.db setup from babelmixr2. With the windows parallelization, this environment is sent to every R process node to load the DLLs. This will allow everything to be contained inside of babelmixr2 in case things like symbolic sensitivity gradient models are added to speed up PopED and rxode2. Right now there are 2 models/dlls generated for each poped database.

@mattfidler
Copy link
Contributor Author

Had to add babelmixr2 development stack so these check correctly. After adding this to CRAN you can take out the babelmixr2 stack and can simply use the CRAN version.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 60.97561% with 32 lines in your changes missing coverage. Please review.

Project coverage is 44.68%. Comparing base (1b8c9cc) to head (63f3442).

Files with missing lines Patch % Lines
R/start_parallel.R 0.00% 5 Missing ⚠️
R/optimize_n.R 40.00% 3 Missing ⚠️
R/blockexp.R 0.00% 2 Missing ⚠️
R/ind_estimates.R 0.00% 2 Missing ⚠️
R/LEDoptim.R 0.00% 1 Missing ⚠️
R/LinMatrixLH.R 50.00% 1 Missing ⚠️
R/LinMatrixL_occ.R 0.00% 1 Missing ⚠️
R/blockopt.R 0.00% 1 Missing ⚠️
R/blockother.R 0.00% 1 Missing ⚠️
R/create_ofv.R 0.00% 1 Missing ⚠️
... and 14 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   44.52%   44.68%   +0.15%     
==========================================
  Files         120      121       +1     
  Lines        8810     8892      +82     
==========================================
+ Hits         3923     3973      +50     
- Misses       4887     4919      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattfidler
Copy link
Contributor Author

As babelmixr2 was released on CRAN development libraries are no longer neeeded.

@mattfidler
Copy link
Contributor Author

The error in oldrel-1 is unrelated to this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant