moved main app logic to cljc #1
Conversation
| (let [label-offset -10 ;; TODO | ||
| ] | ||
| [:g.axis | ||
| {:transform (css-str [(rotate angle begin-x begin-y) (translate begin-x begin-y)])} |
There was a problem hiding this comment.
Looks interesting, but seems to add a bit of complexity
Not sure it's a gain here and in the func declarations above ^
It's a fine-looking interpolation though, better than 'format'
| (defn make-state [] | ||
| spec*) | ||
|
|
||
| (defn update-top-speeds [state {n :n}] |
There was a problem hiding this comment.
If data to be spec-generated, we'll have a 'seed' with some cornerstone for spec-generation parameters that we'll change
e.g. :number-of-entities
That change will trigger re-generation of fine-to-consume by chart logic data
| [charting-around.core :as c] | ||
| [charting-around.views :as v])) | ||
|
|
||
| (defn root-view |
There was a problem hiding this comment.
Generally I'm against any ahead of time architecture, generalization (in code, ns)
ns architecture may make thinking less consuming, as we switch to context and are spared of constant need filtering of relevant information, but in pre-mature separation there is not much to filter, but a ns dependency to manage (those tasty ns-require conflicts and need to connect nses)
Trying to keep it simple until tradeoff worth it for sure
There was a problem hiding this comment.
It's about move to .cljc too: - interop, + ns, + connect ns, + ugly syntax if we do need interop
reason?
|
|
||
| (defn ready-axis [{:keys [domain] :as axis} [[begin-x begin-y] [end-x end-y] :as coords]] | ||
| (let [displacement [(- end-x begin-x) (- end-y begin-y)] | ||
| range (js/Math.hypot (first displacement) (second displacement))] | ||
| range (Math/hypot (first displacement) (second displacement))] |
separated view/app into separate namespaces, moved non-CLJS-specific code to .cljc