This repository has been archived by the owner on Nov 14, 2018. It is now read-only.
Get the MIME type from File and UrlEncode #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobiasschuerg What if there are spaces in your file path? It will not work in that condition. You need to use encode uri for that purpose. Like, |
phu2524
approved these changes
Mar 21, 2018
Sathawale27
reviewed
Mar 22, 2018
| * @return The MIME type for the files' extension or null iff there is none. | ||
| */ | ||
| fun File.getMimeType(): String? { | ||
| return MimeTypeMap.getFileExtensionFromUrl(toString().urlEncode()) |
There was a problem hiding this comment.
IMHO, We can use path instead of toString() as it easy to understand.
Sathawale27
reviewed
Mar 22, 2018
| @file:Suppress("NOTHING_TO_INLINE") // Aliases to public API. | ||
| @file:Suppress("NOTHING_TO_INLINE") | ||
|
|
||
| // Aliases to public API. |
There was a problem hiding this comment.
nit: Remove extra spaces. Keep this consistent as others.
Sathawale27
reviewed
Mar 22, 2018
| * Returns the MIME type (content type) of this [File]. | ||
| * | ||
| * @see MimeUtils | ||
| * @return The MIME type for the files' extension or null iff there is none. |
There was a problem hiding this comment.
nit: There should be "if" instead of "iff"
mekarthedev
reviewed
Mar 24, 2018
| * @see MimeUtils | ||
| * @return The MIME type for the files' extension or null if there is none. | ||
| */ | ||
| fun File.getMimeType(): String? { |
There was a problem hiding this comment.
The syntax seems confusing:
- In Kotlin we have properties. Declaring a method instead of a property may be used as a way of paying reader's attention to a possible heavy computations behind the call. I'm not sure about
getMimeTypeFromExtension's performance. But if it is not so time consuming, declaring it as a property seems a better choice. - The name. After I've read
file.getMimeType()the first time, my first impression was "hmm, does it guesses mime type by reading first few bytes of a file?". Then I read implementation and found it actually usesgetMimeTypeFromExtensionand doesn't read file content. Note how SDK's naming pays attention to the way the mime type is guessed. This implementation detail may be important at the call site.
I'd suggest to declare it as val File.mimeTypeFromExtension: String? or fun File.guessMimeTypeFromExtension(): String?.
tobiasschuerg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the MIME type of a
Filevia