Add an example of Shared elements that are seekable using SeekableTransitionState #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
mlykotom
reviewed
Dec 10, 2024
|
When I cancel the back gesture, then it doesn't work again :( broken.mp4 |
…/snippets into predictive-back-seekable
mlykotom
reviewed
Dec 10, 2024
Comment on lines
658
to
669
| try { | ||
| seekableTransitionState.seekTo(backEvent.progress, targetState = Screen.Home) | ||
| } catch (e: CancellationException) { | ||
| // ignore the cancellation | ||
| } | ||
| } | ||
| // code for completion | ||
| seekableTransitionState.animateTo(seekableTransitionState.targetState) | ||
| } catch (e: CancellationException) { | ||
| // code for cancellation | ||
| seekableTransitionState.animateTo(seekableTransitionState.currentState) | ||
| } |
There was a problem hiding this comment.
I find it slightly confusing why do I need to suppress the cancellation exceptions here.
Can we explain it a bit more in the comments? 🙏🏼
Fixed this by changing to snapTo instead of animateTo in the cancellation block, could you try it again? |
mlykotom
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example of seekable transitions, was previously approved by Doris but pull request got outdated. #273