Remove @SuppressLint("RestrictedApi") #99
Conversation
To access APIs of tvprovider library without warnings. Bug: 138150076
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -143,8 +143,6 @@ object WatchNextHelper { | |||
| /** | |||
| * Retrieve all programs in Watch Next row. | |||
| */ | |||
| @SuppressLint("RestrictedApi") | |||
There was a problem hiding this comment.
Unfortunately the referenced library is restricted, so this lint suppression is needed here.
There was a problem hiding this comment.
This removal can be merged now that bug #138150076 has been resolved.
There was a problem hiding this comment.
@ittiam-sham Removal of RestrictedApi looks good, but please comment on the other changes or revert them.
| ) | ||
| ) | ||
| val programBuilder = | ||
| values?.getAsString(TvContractCompat.WatchNextPrograms.COLUMN_TITLE)?.let { |
There was a problem hiding this comment.
What is the purpose of this refactoring? Reading the value first and providing it as a lambda is more difficult to understand, in my opinion.
| values?.getAsString( | ||
| TvContractCompat | ||
| .WatchNextPrograms.COLUMN_INTERNAL_PROVIDER_ID | ||
| val program = values?.getAsString( |
There was a problem hiding this comment.
Same comment here as above.
To access APIs of tvprovider library without warnings.
Bug: 138150076