Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for search occurrences count and search navigation #338

Merged
merged 3 commits into from
Feb 22, 2025
Merged

Add support for search occurrences count and search navigation #338

merged 3 commits into from
Feb 22, 2025

Conversation

kpchandora
Copy link
Contributor

@kpchandora kpchandora commented Feb 22, 2025 •
edited
Loading

Fixes: #337

Screenshot_20250222_194335

@srtvprateek srtvprateek merged commit 7e72a23 into androidPluto:develop Feb 22, 2025
5 checks passed
@srtvprateek
Copy link
Member

@kpchandora thanks for the contribution,
liked the approach of bringing the current occurrence in focus.

Can we also add a different highlight color for the currently focused occurrence? This'll improve the readability.

@kpchandora kpchandora deleted the enhanced-search-for-network-response branch February 23, 2025 05:37
@kpchandora
Copy link
Contributor Author

@srtvprateek Sure, I will add that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srtvprateek srtvprateek srtvprateek approved these changes

Assignees
No one assigned
Labels
core network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Search Functionality with Navigation & Occurrence Count
2 participants
@kpchandora @srtvprateek