plugins 2: no more plugins #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twizmwazin
force-pushed
the
feat/plugins2
branch
from
b69c2fc to
919a795
Compare
twizmwazin
force-pushed
the
feat/plugins2
branch
from
919a795 to
45cd9ce
Compare
twizmwazin
force-pushed
the
feat/plugins2
branch
from
45cd9ce to
93cd6fa
Compare
twizmwazin
force-pushed
the
feat/plugins2
branch
2 times, most recently
from
ca58742 to
55f3fea
Compare
|
Tests are still using archinfo, fixing those up then plan to merge |
twizmwazin
force-pushed
the
feat/plugins2
branch
from
331643d to
52d283f
Compare
twizmwazin
force-pushed
the
feat/plugins2
branch
2 times, most recently
from
6a71c92 to
a7cd26e
Compare
twizmwazin
force-pushed
the
feat/plugins2
branch
from
a7cd26e to
bc8e5a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We begin by discarding all previously held notions of what is good and just. The things that are good and just are the things that work. We must not have the dependency cycle; this is bad. Pyvex cannot be refactored to not use arch, this is bad. Making archinfo not depend on pyvex is a fool's errand, this is bad. Therefore, pyvex must put its finger to its lips and claim, "I do not depend on archinfo".
It's still not good. But it does work.