chore: add import lint plugin for sorting imports

.eslintrc.json

@@ -1,7 +1,7 @@
 {
   "root": true,
   "ignorePatterns": ["**/*"],
-  "plugins": ["@nx"],
+  "plugins": ["import", "@nx"],
   "overrides": [
     {
       "files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
@@ -24,6 +24,24 @@
           {
             "argsIgnorePattern": "^_"
           }
+        ],
+        "import/order": [
+          "error",
+          {
+            "groups": [
+              "builtin",
+              "external",
+              "internal",
+              "parent",
+              "sibling",
+              "index"
+            ],
+            "newlines-between": "always",
+            "alphabetize": {
+              "order": "asc",
+              "caseInsensitive": true
+            }
+          }
         ]
       }
     },

.github/workflows/pipeline.yaml → .github/workflows/build.yaml

@@ -9,7 +9,7 @@ on:
       - main
 
 jobs:
-  lint_and_test:
+  build_job:
     runs-on: ubuntu-latest
 
     steps:

README.md

@@ -47,7 +47,7 @@ In case users have used multiple names, as appearing in the `git log`, use the `
 {
   [...]
   "aliases": {
-    "jdoe": "John Doe", 
+    "jdoe": "John Doe",
     "janedoe": "Jane Doe"
   }
   [...]

apps/backend/src/express.ts

@@ -1,22 +1,24 @@
-import express from 'express';
-import path from 'path';
 import fs from 'fs';
-import { calcCoupling } from './services/coupling';
+import path from 'path';
 import { cwd } from 'process';
+
+import express from 'express';
+
+import { getCommitCount } from './infrastructure/git';
+import { Limits } from './model/limits';
+import { Options } from './options/options';
+import { calcChangeCoupling } from './services/change-coupling';
+import { calcCoupling } from './services/coupling';
 import { inferFolders } from './services/folders';
-import { calcModuleInfo } from './services/module-info';
-import { calcTeamAlignment } from './services/team-alignment';
 import {
   aggregateHotspots,
   ComplexityMetric,
   findHotspotFiles,
   HotspotCriteria,
 } from './services/hotspot';
-import { calcChangeCoupling } from './services/change-coupling';
-import { Options } from './options/options';
-import { Limits } from './model/limits';
 import { isStale, updateLogCache } from './services/log-cache';
-import { getCommitCount } from './infrastructure/git';
+import { calcModuleInfo } from './services/module-info';
+import { calcTeamAlignment } from './services/team-alignment';
 
 export function setupExpress(options: Options) {
   const app = express();

apps/backend/src/infrastructure/config.ts

@@ -1,8 +1,10 @@
+import fs from 'fs';
 import path from 'path';
 import { cwd } from 'process';
+
 import { Config } from '../model/config';
 import { Options } from '../options/options';
-import fs from 'fs';
+
 import { DETECTIVE_DIR } from './paths';
 
 const initConfig: Config = {

apps/backend/src/infrastructure/deps.ts

@@ -1,10 +1,13 @@
-import { Options } from '../options/options';
-import { Deps } from '../model/deps';
 import fs from 'fs';
+import { cwd } from 'process';
+
 import { getProjectData } from '@softarc/sheriff-core';
 import { globSync } from 'fast-glob';
+
+import { Deps } from '../model/deps';
+import { Options } from '../options/options';
+
 import { loadConfig } from './config';
-import { cwd } from 'process';
 
 const DEFAULT_ENTRIES = [
   'src/main.ts',

apps/backend/src/infrastructure/git.ts

@@ -1,6 +1,7 @@
+import { spawn, spawnSync } from 'child_process';
 import * as fs from 'fs';
+
 import { noLimits } from '../model/limits';
-import { spawn, spawnSync } from 'child_process';
 
 export function isRepo(): boolean {
   return fs.existsSync('.git');

apps/backend/src/infrastructure/log.ts

@@ -1,5 +1,6 @@
 import * as fs from 'fs';
 import * as path from 'path';
+
 import { DETECTIVE_DIR, LOG_FILE } from './paths';
 
 const logFile = path.join(DETECTIVE_DIR, LOG_FILE);

apps/backend/src/infrastructure/tree-hash.ts

@@ -1,5 +1,6 @@
 import * as fs from 'fs';
 import * as path from 'path';
+
 import { DETECTIVE_DIR, HASH_FILE } from './paths';
 
 const hashFile = path.join(DETECTIVE_DIR, HASH_FILE);

apps/backend/src/main.ts

@@ -1,12 +1,12 @@
 #!/usr/bin/env node
 
-import { parseOptions } from './options/parse-options';
+import { setupExpress } from './express';
 import { ensureConfig } from './infrastructure/config';
 import { getEntryGlobs, inferDeps } from './infrastructure/deps';
 import { isRepo } from './infrastructure/git';
-import { openSync } from './utils/open';
-import { setupExpress } from './express';
 import { DETECTIVE_VERSION } from './infrastructure/version';
+import { parseOptions } from './options/parse-options';
+import { openSync } from './utils/open';
 
 const options = parseOptions(process.argv.slice(2));
 

apps/backend/src/options/validate-options.ts

@@ -1,6 +1,7 @@
-import { Options } from './options';
 import fs from 'fs';
 
+import { Options } from './options';
+
 export function validateOptions(options: Options) {
   try {
     if (!fs.existsSync(options.sheriffDump)) {

apps/backend/src/services/change-coupling.spec.ts

@@ -1,6 +1,7 @@
 import { emptyConfig } from '../model/config';
 import { Limits } from '../model/limits';
 import { defaultOptions } from '../options/options';
+
 import { calcChangeCoupling } from './change-coupling';
 
 const now = new Date();

apps/backend/src/services/coupling.spec.ts

@@ -1,7 +1,8 @@
 import { emptyConfig } from '../model/config';
+import { Deps } from '../model/deps';
 import { defaultOptions } from '../options/options';
+
 import { calcCoupling } from './coupling';
-import { Deps } from '../model/deps';
 
 const scopes = ['/booking', '/checkin', '/shared'];
 

apps/backend/src/services/coupling.ts

@@ -1,11 +1,12 @@
-import { Deps } from '../model/deps';
-import { Options } from '../options/options';
 import { loadConfig } from '../infrastructure/config';
 import { loadDeps } from '../infrastructure/deps';
-import { calcModuleInfo, ModuleInfo } from './module-info';
-import { toPercent } from '../utils/to-percent';
+import { Deps } from '../model/deps';
+import { Options } from '../options/options';
 import { getEmptyMatrix } from '../utils/matrix';
 import { normalizeFolder } from '../utils/normalize-folder';
+import { toPercent } from '../utils/to-percent';
+
+import { calcModuleInfo, ModuleInfo } from './module-info';
 
 export type CouplingResult = {
   groups: string[];

apps/backend/src/services/folders.spec.ts

@@ -1,7 +1,8 @@
 import { emptyConfig } from '../model/config';
+import { Deps } from '../model/deps';
 import { defaultOptions } from '../options/options';
+
 import { inferFolders } from './folders';
-import { Deps } from '../model/deps';
 
 const scopes = ['/booking', '/checkin', '/shared'];
 

apps/backend/src/services/folders.ts

@@ -1,5 +1,5 @@
-import { Options } from '../options/options';
 import { loadDeps } from '../infrastructure/deps';
+import { Options } from '../options/options';
 
 export type Folder = {
   name: string;

apps/backend/src/services/hotspot.spec.ts

@@ -1,6 +1,7 @@
 import { emptyConfig } from '../model/config';
 import { Limits } from '../model/limits';
 import { defaultOptions } from '../options/options';
+
 import {
   aggregateHotspots,
   findHotspotFiles,

apps/backend/src/services/hotspot.ts

@@ -1,15 +1,14 @@
-import path from 'path';
 import * as fs from 'fs';
+import path from 'path';
 
-import { Options } from '../options/options';
-import { LogBodyEntry, parseGitLog, ParseOptions } from '../utils/git-parser';
 import { loadConfig } from '../infrastructure/config';
-import { normalizeFolder, toDisplayFolder } from '../utils/normalize-folder';
+import { Filter } from '../model/config';
 import { Limits } from '../model/limits';
-
+import { Options } from '../options/options';
 import { calcCyclomaticComplexity } from '../utils/complexity';
 import { countLinesInFile } from '../utils/count-lines';
-import { Filter } from '../model/config';
+import { LogBodyEntry, parseGitLog, ParseOptions } from '../utils/git-parser';
+import { normalizeFolder, toDisplayFolder } from '../utils/normalize-folder';
 
 export type ComplexityMetric = 'McCabe' | 'Length';
 

apps/backend/src/services/log-cache.ts

@@ -1,6 +1,6 @@
-import { loadTreeHash, saveTreeHash } from '../infrastructure/tree-hash';
 import { calcTreeHash, getGitLog } from '../infrastructure/git';
 import { saveCachedLog } from '../infrastructure/log';
+import { loadTreeHash, saveTreeHash } from '../infrastructure/tree-hash';
 import { DETECTIVE_VERSION } from '../infrastructure/version';
 
 export function isStale(): boolean {

apps/backend/src/services/team-alignment.spec.ts

@@ -1,6 +1,7 @@
 import { emptyConfig } from '../model/config';
 import { Limits } from '../model/limits';
 import { defaultOptions, Options } from '../options/options';
+
 import { calcTeamAlignment } from './team-alignment';
 
 const now = new Date();

apps/backend/src/utils/complexity.ts

@@ -1,6 +1,7 @@
-import * as ts from 'typescript';
 import * as fs from 'fs';
 
+import * as ts from 'typescript';
+
 export function calcCyclomaticComplexity(fileName: string): number {
   const code = fs.readFileSync(fileName, 'utf-8');
   return calcComplexityForCode(code);

apps/backend/src/utils/git-parser.spec.ts

@@ -1,7 +1,8 @@
+import { loadCachedLog } from '../infrastructure/log';
 import { emptyConfig } from '../model/config';
-import { LogEntry, parseGitLog, ParseOptions } from './git-parser';
 import { getToday, subtractMonths, subtractSeconds } from '../utils/date-utils';
-import { loadCachedLog } from '../infrastructure/log';
+
+import { LogEntry, parseGitLog, ParseOptions } from './git-parser';
 
 const today = getToday();
 const past = subtractSeconds(subtractMonths(today, 1), 1);

apps/backend/src/utils/git-parser.ts

@@ -1,9 +1,11 @@
 import * as path from 'path';
-import { Limits, noLimits } from '../model/limits';
+
+import microMatch from 'micromatch';
+
 import { loadCachedLog } from '../infrastructure/log';
-import { getToday, subtractMonths } from '../utils/date-utils';
 import { Filter } from '../model/config';
-import microMatch from 'micromatch';
+import { Limits, noLimits } from '../model/limits';
+import { getToday, subtractMonths } from '../utils/date-utils';
 
 type State = 'header' | 'body' | 'skip';
 

apps/frontend/src/app/app.component.ts

@@ -1,7 +1,8 @@
 import { Component, inject, OnInit } from '@angular/core';
 import { RouterOutlet } from '@angular/router';
-import { NavComponent } from './shell/nav/nav.component';
+
 import { StatusStore } from './data/status.store';
+import { NavComponent } from './shell/nav/nav.component';
 
 @Component({
   selector: 'app-root',

apps/frontend/src/app/app.config.ts

@@ -1,15 +1,14 @@
+import { provideHttpClient } from '@angular/common/http';
 import {
   ApplicationConfig,
   importProvidersFrom,
   provideZoneChangeDetection,
 } from '@angular/core';
-import { provideRouter, withComponentInputBinding } from '@angular/router';
-
 import { MatDialogModule } from '@angular/material/dialog';
+import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
+import { provideRouter, withComponentInputBinding } from '@angular/router';
 
 import { routes } from './app.routes';
-import { provideHttpClient } from '@angular/common/http';
-import { provideAnimationsAsync } from '@angular/platform-browser/animations/async';
 import { AppErrorHandler, provideErrorHandler } from './utils/error-handler';
 
 export const appConfig: ApplicationConfig = {

apps/frontend/src/app/app.routes.ts

@@ -1,10 +1,11 @@
-import { Routes, ActivatedRoute } from '@angular/router';
+import { Routes } from '@angular/router';
+
 import { CouplingComponent } from './features/coupling/coupling.component';
-import { GraphTypeData } from './model/graph-type';
-import { ensureCache } from './shell/cache.guard';
 import { HotspotComponent } from './features/hotspot/hotspot.component';
 import { TeamAlignmentComponent } from './features/team-alignment/team-alignment.component';
+import { GraphTypeData } from './model/graph-type';
 import { AboutComponent } from './shell/about/about.component';
+import { ensureCache } from './shell/cache.guard';
 
 export const routes: Routes = [
   {

apps/frontend/src/app/data/cache.service.ts

@@ -1,8 +1,9 @@
 import { HttpClient } from '@angular/common/http';
 import { inject, Injectable } from '@angular/core';
-import { CacheStatus } from '../model/cache-status';
 import { Observable } from 'rxjs';
 
+import { CacheStatus } from '../model/cache-status';
+
 @Injectable({ providedIn: 'root' })
 export class CacheService {
   private http = inject(HttpClient);

apps/frontend/src/app/data/config.service.ts

@@ -1,6 +1,7 @@
 import { HttpClient } from '@angular/common/http';
 import { inject, Injectable } from '@angular/core';
 import { Observable } from 'rxjs';
+
 import { Config } from '../model/config';
 
 @Injectable({ providedIn: 'root' })

apps/frontend/src/app/data/coupling.service.ts

@@ -1,6 +1,7 @@
 import { HttpClient } from '@angular/common/http';
 import { inject, Injectable } from '@angular/core';
 import { Observable } from 'rxjs';
+
 import { CouplingResult } from '../model/coupling-result';
 import { GraphType } from '../model/graph-type';
 import { initLimits } from '../model/limits';