Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show actual teams/users in team alignment #24

Merged

Conversation

wamasimba
Copy link

@wamasimba wamasimba commented Sep 29, 2024

It struck me as odd that I saw a team "unknown", whereas the users were all collected in appropriate teams, also I saw teams that did not contribute to the selected branch in the tree; this PR fixes that, by always returning the actual teams that are resulting from a team alignment analysis. The team/user names are sorted alfabetically to have a more or less predictable outcome, and by chance separate the most active users somewhat, making the colored donut charts slightly easier to analyse.

BEFORE:

When 'By user' is not selected, all teams are shown, including a artificial team 'unknown', even when a team or 'unknown' was actually not part of the analysis.

AFTER:

Only teams that occur in the analysis are shown.

Checklist for PR

  • PR is only about one and only one concern
  • Description contains a short title, an optional description, and the sections BEFORE and AFTER
  • (A) new short test(s) show(s) that the PR is working (shown in adapted existing test)

@manfredsteyer manfredsteyer merged commit a722a19 into angular-architects:main Oct 15, 2024
1 check passed
@manfredsteyer
Copy link
Contributor

Big thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants