serializing bigint #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainerhahnekamp
requested changes
Apr 14, 2024
| @@ -1,14 +1,16 @@ | |||
| import { getState, patchState, signalStore, withState } from '@ngrx/signals'; | |||
| import { withStorageSync } from './with-storage-sync'; | |||
| import { withBigIntRehydration, withBigIntReplacement, withStorageSync } from './with-storage-sync'; | |||
There was a problem hiding this comment.
Would it be possible to rename withBigIntRehydration and withBigIntReplacement to serialize and deserialize. I think bigint will not be the last type where we require custom code.
| import { TestBed } from '@angular/core/testing'; | ||
|
|
||
| interface StateObject { | ||
| foo: string; | ||
| age: number; | ||
| big: bigint; |
There was a problem hiding this comment.
Would it be possible, that we leave the tests as they are and just create a separate test which checks the de/serialization for bigint?
package-lock.json
Outdated
There was a problem hiding this comment.
I don't think that the package-lock.json should be changed, right?
| @@ -58,15 +104,20 @@ export type SyncConfig<State> = { | |||
| /** | |||
| * Function used to parse the state coming from storage. | |||
| * | |||
| * `JSON.parse()` by default | |||
| * ~~`JSON.parse()` by default~~ | |||
There was a problem hiding this comment.
Yes, you can replace that with parse and stringify (below).
|
Sorry for the late reply. Yes. I will take care of it. Thanks for the
comments.
|
|
@robmanganelly if you don't have the time, no worries. We'll merge and I can do the changes myself. Just let me know, cheers! |
|
Honestly, I don't want to pass the workload onto you guys. I'm really happy
to contribute to this project, even if my contributions are minuscule, but
I currently don't have the bandwidth, sadly, for which I apologize.
I can reach out once I'm done with my current tasks, and if changes are
still needed, I'll be more than happy to handle them myself.
Otherwise, please proceed as you see fit.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content of this PR:
Considerations.