feat: allow globbing

[filipesilva]

Close #21

Globbing files

$ clang-format --glob=folder/**/*.js

This will run clang-format once per file result, and show the total formatted files at the end.

[alexeagle]

We need to document what the globbing semantics are. It's sufficient to point to the docs for the glob library we use.

[filipesilva]

Roger, will add this.

[filipesilva]

Added link to glob semantics, chunking files in sets of 30, added serial execution of spawned processes.

[alexeagle]

seems like a funny name for it now. Is the library worth having the dependency now, rather than just a for loop?

[filipesilva]

Well the operation itself (spawning a child process and waiting for it to end) is still async so a simple for loop wouldn't work.

I could replicate async's series functionality with a well crafted recursive function, but async does it better and is more well tested so it seemed a better fit for this wrapper.

[alexeagle]

LGTM
Do you need a merge/release? maybe you don't have permissions

[filipesilva]

Index 0 matching is in. But something seems breaking in the tests... give me a sec.

[filipesilva]

Nvm, was just running the wrong tests. It's good to go.

I don't have permissions, no. Could you perhaps do it?

[alexeagle]

Merged in cfd69a8 - thanks!!!

[filipesilva]

Sweet.

[alexeagle]

Just realized that we don't afford a way to pass options - I was just trying to write up an example and need exclude...

[mprobst]

Could you add docs that this is of course a Windows-only issue, and that on UNIXens including Macs the shell itself is doing the globbing?

To that point, I think it might be smarter to not have --glob=...., but rather just check if the machine is running on Windows, and then glob over the regular arguments. That'd allow users to run mostly the same command line on Linux, Macs, and Windows, which is nice for consistent development environments.

[alexeagle]

The use case I have for this is in package.json

"scripts": {
  "format": "clang-format --glob **/*.ts"
}

This command needs to be cross-platform, and I don't want to use only the shell (can't get recursive globs without some platform dependent helper)

[filipesilva]

@alexeagle can you check if these proposal fits your needs? #25 (comment) (including @mprobst comment, that you probably have to expand the ... to see).