feat(style): allow palettes to specify a separate hue for colored text #15149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benelliott
requested review from
crisbeto,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
|
I couldn't run the pre-commit hooks due to this issue with clang-format. |
josephperrott
added
the
target: minor
jelbourn
reviewed
Feb 20, 2019
src/lib/core/theming/_theming.scss
Outdated
| @@ -14,11 +14,12 @@ | |||
| // @param $color-map | |||
| // @param $primary | |||
| // @param $lighter | |||
| @function mat-palette($base-palette, $default: 500, $lighter: 100, $darker: 700) { | |||
| @function mat-palette($base-palette, $default: 500, $lighter: 100, $darker: 700, $text: 500) { | |||
There was a problem hiding this comment.
I kept it to $text for consistency with $default etc - but happy to change it
There was a problem hiding this comment.
That's fair- they're all hues now that I think about it.
jelbourn
added
pr: lgtm
action: merge
benelliott
force-pushed
the
palette-text-hue
branch
from
fca738b to
0adce23
Compare
benelliott
force-pushed
the
palette-text-hue
branch
from
0adce23 to
cb6a989
Compare
andrewseguin
added
the
P3
RudolfFrederiksen
pushed a commit
to RudolfFrederiksen/material2
that referenced
this pull request
Jun 21, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
texthue will default to 500 for backwards compatibility.Fixes #15148