chore(cluster_merger): rework parameters (autowarefoundation#6165)

chore(cluster_merger): organize parameter Signed-off-by: kminoda <[email protected]> Signed-off-by: anhnv3991 <[email protected]>
anhnv3991 · Jan 29, 2024 · 92eaaf6 · 92eaaf6
1 parent 2c19f24
commit 92eaaf6
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/perception/cluster_merger/CMakeLists.txt b/perception/cluster_merger/CMakeLists.txt
@@ -24,4 +24,5 @@ endif()
 ament_auto_package(
   INSTALL_TO_SHARE
   launch
+  config
 )
diff --git a/perception/cluster_merger/config/cluster_merger.param.yaml b/perception/cluster_merger/config/cluster_merger.param.yaml
@@ -0,0 +1,3 @@
+/**:
+  ros__parameters:
+    output_frame_id: "base_link"
diff --git a/perception/cluster_merger/launch/cluster_merger.launch.xml b/perception/cluster_merger/launch/cluster_merger.launch.xml
@@ -3,12 +3,12 @@
   <arg name="output/clusters" default="output/clusters"/>
   <arg name="input/cluster0" default="input/cluster0"/>
   <arg name="input/cluster1" default="input/cluster1"/>
-  <arg name="output_frame_id" default="base_link"/>
+  <arg name="param_path" default="$(find-pkg-share cluster_merger)/config/cluster_merger.param.yaml"/>
   <!-- Node -->
   <node pkg="cluster_merger" exec="cluster_merger_node" name="cluster_merger" output="screen">
     <remap from="~/output/clusters" to="$(var output/clusters)"/>
     <remap from="input/cluster0" to="$(var input/cluster0)"/>
     <remap from="input/cluster1" to="$(var input/cluster1)"/>
-    <param name="output_frame_id" value="$(var output_frame_id)"/>
+    <param from="$(var param_path)"/>
   </node>
 </launch>
-Original file line number
+Diff line change
@@ Expand Up / @@ -24,4 +24,5 @@ endif() @@
     ament_auto_package(
       INSTALL_TO_SHARE
       launch
+      config
     )