-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixup(ui): make the default list a set size and make browse list scale #1914
base: main
Are you sure you want to change the base?
Conversation
658aec4
to
214b0e4
Compare
I also noticed the list size setting doesn't apply when browsing sources. In contrast, the grid size is the same as in the library view |
You're absolutely right. For some reason I thought that browse grids just stick to the default size. I'll start on fixing that. |
I am not sure if this'd work but have you tried using Intrinsic measurements? |
It's the linter complaining about the code style, you can (probably) fix it with |
bfca4ab
to
69d7987
Compare
Yeah, I think this is done. When (and if) this gets merged, I'll reopen the identical PR in mihon with these fixes as well. |
I came to the conclusion that setting number 7 as the default wouldn't be ideal. Some people might've enjoyed the original list because it would scale with their phone UI if they changed it. I now made the default to be a set value like both the migration list and browse list. It doesn't take away any options because users can just put 7 themselves on the slider. And it's faithful to the previous list.
it's a 3 line change, guys. I hope someone can find some time to merge this in.
(fixup to 2b1dbc1)
Edit: well... it's a bit more than 3 lines now, but it now fixes a glitch where the browse list didn't scale like the library list does.