Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup(ui): make the default list a set size and make browse list scale #1914

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MavikBow
Copy link
Contributor

@MavikBow MavikBow commented Jan 31, 2025

I came to the conclusion that setting number 7 as the default wouldn't be ideal. Some people might've enjoyed the original list because it would scale with their phone UI if they changed it. I now made the default to be a set value like both the migration list and browse list. It doesn't take away any options because users can just put 7 themselves on the slider. And it's faithful to the previous list.

it's a 3 line change, guys. I hope someone can find some time to merge this in.

(fixup to 2b1dbc1)

Edit: well... it's a bit more than 3 lines now, but it now fixes a glitch where the browse list didn't scale like the library list does.

@jmir1
Copy link
Member

jmir1 commented Jan 31, 2025

I also noticed the list size setting doesn't apply when browsing sources. In contrast, the grid size is the same as in the library view

@MavikBow
Copy link
Contributor Author

You're absolutely right. For some reason I thought that browse grids just stick to the default size. I'll start on fixing that.

@MavikBow
Copy link
Contributor Author

MavikBow commented Feb 1, 2025

I'm currently struggling with the issue that the Lazy Column wherein the list is located gives me the height of the entire screen instead of its visible area. So at the moment (not committed yet) it does scale, but for the whole screen :/

Screenshot_20250201-124600_Aniyomi Screenshot_20250201-124611_Aniyomi

@abdallahmehiz
Copy link
Member

abdallahmehiz commented Feb 1, 2025

I am not sure if this'd work but have you tried using Intrinsic measurements?
https://developer.android.com/develop/ui/compose/layouts/intrinsic-measurements

@MavikBow
Copy link
Contributor Author

MavikBow commented Feb 1, 2025

Alright, now works as intended:

Screenshot_20250201-164327_Aniyomi Screenshot_20250201-164250_Aniyomi

Intrinsic measurements didn't help, had to subtract the height of the bar above.

I call bs on this build test. Execution failed for task ':app:spotlessKotlinCheck'.
Idk what it wants the indentation to look like, everything compiles and works for me.

@Secozzi
Copy link
Contributor

Secozzi commented Feb 1, 2025

call bs on this build test.

It's the linter complaining about the code style, you can (probably) fix it with ./gradlew spotlessApply

@MavikBow
Copy link
Contributor Author

MavikBow commented Feb 2, 2025

Yeah, I think this is done. When (and if) this gets merged, I'll reopen the identical PR in mihon with these fixes as well.

@MavikBow MavikBow changed the title fixup(ui): make the default list size faithful to the prior version fixup(ui): make the default list a set size and make browse list scale Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants