fix(sync): notification getting stuck

cancel it after the work is done in case it wasn't dismissed
ankidroid · Feb 9, 2025 · ce9eb68 · ce9eb68
1 parent 168cad0
commit ce9eb68
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/worker/SyncMediaWorker.kt b/AnkiDroid/src/main/java/com/ichi2/anki/worker/SyncMediaWorker.kt
@@ -84,6 +84,9 @@ class SyncMediaWorker(
                 setContentTitle(CollectionManager.TR.syncMediaFailed())
             }
             return Result.failure()
+        } finally {
+            Timber.d("SyncMediaWorker: cancelling notification")
+            notificationManager.cancel(NotificationId.SYNC_MEDIA)
         }
 
         Timber.d("SyncMediaWorker: success")

diff --git a/AnkiDroid/src/main/java/com/ichi2/anki/worker/SyncWorker.kt b/AnkiDroid/src/main/java/com/ichi2/anki/worker/SyncWorker.kt
@@ -104,6 +104,9 @@ class SyncWorker(
                 setContentTitle(applicationContext.getString(R.string.sync_error))
             }
             return Result.failure()
+        } finally {
+            Timber.d("SyncWorker: cancelling notification")
+            notificationManager.cancel(NotificationId.SYNC)
         }
 
         Timber.d("SyncWorker: success")