Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve reposition field dialog #17900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

criticalAY
Copy link
Contributor

@criticalAY criticalAY commented Jan 29, 2025

Purpose / Description

Anki prefill the current position of the field and allow user to update it if they want to, this PR makes the dialog consistent with Anki reposition dialog
Screenshot 2025-01-30 at 2 57 32 AM

Current UI:
Screenshot 2025-01-30 at 3 03 46 AM

How Has This Been Tested?

Google emulator API 31

New UI:
Screenshot 2025-01-30 at 2 57 08 AM

Learning (optional, can help others)

I found this out when I was trying to reproduce some other bug, so just pushing this simple improvement

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@criticalAY criticalAY force-pushed the refactor-reposition-dialog branch from 90841e9 to f8114b3 Compare January 29, 2025 21:33
@criticalAY criticalAY force-pushed the refactor-reposition-dialog branch 2 times, most recently from 91717a4 to 9ee9760 Compare January 31, 2025 13:39
@criticalAY criticalAY force-pushed the refactor-reposition-dialog branch from 9ee9760 to 98d4fcc Compare February 1, 2025 19:12
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@lukstbit lukstbit added the Needs Second Approval Has one approval, one more approval to merge label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Second Approval Has one approval, one more approval to merge Strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants