Prevent double Discard Changes dialog on Android back swipe gesture #17907
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible. |
criticalAY
reviewed
Feb 3, 2025
criticalAY
reviewed
Feb 3, 2025
Comment on lines
+34
to
+42
| isCancellable: Boolean = true, | ||
| negativeMethod: () -> Unit = {}, | ||
| positiveMethod: () -> Unit, | ||
| ) = AlertDialog.Builder(context).show { | ||
| setCancelable(isCancellable) | ||
| Timber.i("showing 'discard changes' dialog") | ||
| message(text = message) | ||
| positiveButton(text = positiveButtonText) { positiveMethod() } | ||
| negativeButton(text = negativeButtonText) | ||
| negativeButton(text = negativeButtonText) { negativeMethod() } |
There was a problem hiding this comment.
You can do the same without changing the original code here, I think that the Discard dialog should be kept simple
criticalAY
reviewed
Feb 3, 2025
| DiscardChangesDialog.showDialog(this, isCancellable = false, negativeMethod = { | ||
| isDialogShowing = false | ||
| }) { | ||
| isDialogShowing = false |
There was a problem hiding this comment.
Can use dismiss listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Instant Card: Double "discard changes" window appears on Android "Back" swipe gesture #17864
Fixes
Approach
To handle the issue effectively, we introduce a flag (
isDialogShowing) to monitor the visibility of the AlertDialog.By default, the AlertDialog gets dismissed when clicked outside, but the flag (
isDialogShowing) remainstrue. This prevents the dialog from appearing again when needed.To address this, we modify the
showDialogfunction in theDiscardChangesDialog.ktfile to accept anisCancellableparameter. SettingsetCancelable(false)ensures that the dialog is not dismissed when clicking outside, allowing us to manage the flag correctly.This update changes the default behavior of this particular AlertDialog, preventing it from being dismissed when clicking outside the dialog. Seeking guidance on whether this change is acceptable.
This approach ensures that
isDialogShowingis updated properly when the dialog is dismissed, preventing unexpected behavior.How Has This Been Tested?
Testedon Android device and attached screen recording.Checklist
Please, go through these checks before submitting the PR.
Uploading screen-rec.mp4…