Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace Press Alt+K to show keyboard shortcuts warning #17934

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented Feb 7, 2025

Fixes

Approach

In the commits. The shortctus helper can be improved later based on David's comment:

Display a help item in the controls settings if a keyboard is attached
Which opens up the keyboard and educates users on the keyboard shortcut for 'Keyboard Shortcuts'
(extension/to discuss) Potentially make it a dismissable banner? It's probably only useful a few times, and then ends up taking up space

How Has This Been Tested?

Android 14 tablet:

The keyboard is being added/removed to check if the helper only appears with a physical keyboard attached.

Screen_Recording_20250207_151136_AnkiDroid.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Contributor

github-actions bot commented Feb 7, 2025

Important

Maintainers: This PR contains Strings changes

  1. Sync Translations before merging this PR and wait for the action to complete
  2. Review and merge the auto-generated PR in order to sync all user-submitted translations
  3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

@BrayanDSO BrayanDSO changed the title Alt k feat: Replace Press Alt+K to show keyboard shortcuts warning Feb 7, 2025
@david-allison david-allison added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 8, 2025
Copy link
Member

@lukstbit lukstbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better.

@lukstbit lukstbit added Needs Author Reply Waiting for a reply from the original author Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) and removed Needs Second Approval Has one approval, one more approval to merge labels Feb 9, 2025
@BrayanDSO BrayanDSO removed the Needs Author Reply Waiting for a reply from the original author label Feb 9, 2025
it shows up the system dialog with the available shortcuts if the user has a physical keyboard attached. It helps the discoverability of keyboard shortcuts along the app.

After the user knows that the app has keyboard shortcuts, they can use the system shortcut (which can be seen in the dialog itself) in any other screen to see the available shortcuts there
@lukstbit lukstbit added this pull request to the merge queue Feb 9, 2025
Merged via the queue into ankidroid:main with commit baf31be Feb 9, 2025
9 checks passed
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR.

Read more about updating strings on the wiki,

@github-actions github-actions bot removed the Pending Merge Things with approval that are waiting future merge (e.g. targets a future release, CI wait, etc) label Feb 9, 2025
@github-actions github-actions bot added this to the 2.21 release milestone Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove/Replace Press Alt+K to show keyboard shortcuts warning
3 participants