-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace Press Alt+K to show keyboard shortcuts
warning
#17934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Important Maintainers: This PR contains Strings changes
|
Press Alt+K to show keyboard shortcuts
warning
david-allison
approved these changes
Feb 8, 2025
AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt
Show resolved
Hide resolved
AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt
Show resolved
Hide resolved
lukstbit
approved these changes
Feb 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better.
AnkiDroid/src/main/java/com/ichi2/anki/preferences/ControlsSettingsFragment.kt
Show resolved
Hide resolved
issue 17633
it shows up the system dialog with the available shortcuts if the user has a physical keyboard attached. It helps the discoverability of keyboard shortcuts along the app. After the user knows that the app has keyboard shortcuts, they can use the system shortcut (which can be seen in the dialog itself) in any other screen to see the available shortcuts there
Maintainers: Please Sync Translations to produce a commit with only the automated changes from this PR. Read more about updating strings on the wiki, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Press Alt+K to show keyboard shortcuts
warning #17633Approach
In the commits. The shortctus helper can be improved later based on David's comment:
How Has This Been Tested?
Android 14 tablet:
The keyboard is being added/removed to check if the helper only appears with a physical keyboard attached.
Screen_Recording_20250207_151136_AnkiDroid.mp4
Checklist
Please, go through these checks before submitting the PR.