Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: instant note editor tap mode inconsistency #17936

Merged
merged 1 commit into from
Feb 8, 2025

Conversation

criticalAY
Copy link
Contributor

Purpose / Description

The note editor mode from view model was not used instead a var from the activity class was used, this PR handles the editor mode via ViewModel and sets the views

Approach

Use mode from view model only

How Has This Been Tested?

before:
Screen_recording_20250208_032036.webm

after:
Screen_recording_20250208_031955.webm

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@criticalAY
Copy link
Contributor Author

@mikehardy
Copy link
Member

@criticalAY yep that's about the only flake at the moment, it's logged (and then I logged a dupe recently even, oops)

@BrayanDSO BrayanDSO added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Feb 8, 2025
@BrayanDSO BrayanDSO mentioned this pull request Feb 8, 2025
5 tasks
@david-allison david-allison added this pull request to the merge queue Feb 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 8, 2025
@criticalAY
Copy link
Contributor Author

Flaky test

@BrayanDSO BrayanDSO added this pull request to the merge queue Feb 8, 2025
Merged via the queue into ankidroid:main with commit fb58917 Feb 8, 2025
12 checks passed
@github-actions github-actions bot added this to the 2.21 release milestone Feb 8, 2025
@github-actions github-actions bot removed the Needs Second Approval Has one approval, one more approval to merge label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants