Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding accurate widget logo for the Widget Small and Widget Add Note in the widget picker screen. #18075

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xenonnn4w
Copy link
Contributor

@xenonnn4w xenonnn4w commented Mar 9, 2025

Fixes

Approach

Adding proper image files for both widgets.

How Has This Been Tested?

Emulator (API-34)
Emulator (API-25)
Physical Device- (API-34)

az.mp4
bz.mp4

Learning (optional, can help others)

Vector file only support few devices where they can directly used in widget picker screen, in other they broke with an error "couldn't load" . This effect can be bypassed by passing them to through a layout file.

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:scaleType="fitCenter"
android:src="@drawable/ic_widget_small" />
Copy link
Contributor Author

@xenonnn4w xenonnn4w Mar 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no string suitable for contentDescription here, the one which i originally found and is being used for this is app_name i.e. "ankidroid".

@xenonnn4w
Copy link
Contributor Author

Note- Theming these is time-consuming, so it will be worked on later after finalizing this or can be done along this pr accordingly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this icon little messy

Copy link
Contributor Author

@xenonnn4w xenonnn4w Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost similar to what will be shown on screen. I acknowledge the clock is bit messy as i was unable to find this exact emote
https://github.com/ankidroid/Anki-Android/pull/17654/files#diff-2c3d03a8b22190f70a1e2f739c2dc5ac862833e78926234168c23be7cae595a0R142
so i have to make a new one. I'll try to improve it soon. Apart from this, if you have any other suggestions for improvement, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants