Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation strings for True Retention table #3745

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rbrownwsws
Copy link
Contributor

Based on this discussion on the forum: https://forums.ankiweb.net/t/anki-25-01-beta/54490/5

I reused translation strings from the Cards Counts chart in the redesign of the True Retention table as it meant less translation work was required.

Unfortunately in some languages these translations are quite long, which can make the table overflow and need scroll bars if the card is small:

image

This PR adds new translation strings specific to the True Retention table so you can do something like this:

statistics-counts-young-cards = Junge Karten
statistics-true-retention-young = Jung

so you can be verbose where you have plenty of space, and terse where you do not.

An unfortunate downside of this is it requires new translations to be added for all languages, which will often be identical to the ones from Card Counts and mean less maintained languages may not get a translation for a while.

This should probably not be merged without input from people more involved in the translation of Anki.

@GithubAnon0000
Copy link

I only translate german which is one of the best translated languages in anki. For german at least, this change wouldn't be an issue at all.

Lesser translated languages would fall back to english for the TR table though, even if technically there already had been translations for the table titles. Not sure if that's a big issue though.

But from my point of view, mainly looking from the german translation side, I'd be fine with this change.

@Danika-Dakika
Copy link

I'm not worried about new strings being added -- as long as you try your best to re-use available strings whenever possible.

Someday we'll finish TR -- but I don't think these strings will delay that!

Since you know these strings have space limitations, if you can figure out how to add a group/resource comment for translators, that would be great.

image

[Translators already get the string character-length for comparison.]

@rbrownwsws
Copy link
Contributor Author

@Danika-Dakika

Since you know these strings have space limitations, if you can figure out how to add a group/resource comment for translators, that would be great.

I've already tried to add comments, hopefully I did it correctly.

I added this to the existing group comment.

ftl/core/statistics.ftl:

  ## True Retention represents your actual retention rate from past reviews, in
  ## comparison to the "desired retention" parameter of FSRS, which forecasts
  ## future retention. True Retention is the percentage of all reviewed cards
  ## that were marked as "Hard," "Good," or "Easy" within a specific time period.
+ ##
+ ## Most of these strings are used as column / row headings in a table.
+ ## (Excluding -title and -subtitle)
+ ## It is important to keep these translations short so that they do not make
+ ## the table too large to display on a single stats card.
+ ##
+ ## N.B. Stats cards may be very small on mobile devices and when the Stats
+ ##      window is certain sizes.

I also added comments like this to hint that they should be similar to the Card Counts values:

+ # This will usually be the same as statistics-counts-young-cards
+ statistics-true-retention-young = Young

@snowtimeglass
Copy link
Contributor

Looks nice to me, too. I thank you because the new string for "Total" here would also be useful in Japanese for expressing the meaning of "Total" in this situation, which is distinguished from simple sum of numbers.


An unfortunate downside of this is it requires new translations to be added for all languages, which will often be identical to the ones from Card Counts and mean less maintained languages may not get a translation for a while.

I guess the solution in the following case would work for this case, as well.

I mean, the translations for the existing strings would be copied (cloned) into the new strings in Pontoon. And then, you, I, and others would rewrite the translations as necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants