Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup av_player on profile close #3754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kelciour
Copy link
Contributor

To reproduce the issue, a profile needs to be opened and closed several times.

The list of players will keep growing in size and include the list of players that were previously instantiated but were shut down on profile close a bit later.

from aqt.sound import av_player

for i, p in enumerate(av_player.players, 1):
  print(i, p)

Before

image

After

image

@YukiNagat0
Copy link
Contributor

self.players.clear() will be more "pythonic" way to do it.

@kelciour kelciour force-pushed the cleanup-avplayer-on-profile-close branch from 455ba92 to 6a52ec9 Compare January 21, 2025 18:59
@kelciour
Copy link
Contributor Author

Thank you! It's been changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants