Recognise and check for media referenced in <source> tags #3763
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamllama
force-pushed
the
media-html-source-tag
branch
from
56c7475 to
349e24c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant post: https://forums.ankiweb.net/t/problem-unused-media-when-exporting-front-back-fields
The media referenced in
<audio controls><source src="blah.mp3" /></audio>isn't currently seen by anki and when doing media checks or exporting, it's treated as unused and isn't exportedIts use is sometimes preferred over
[sound:...]when trying to avoid audio autoplayThis pr fixes that by updating the relevant regex, and testing shows that any file referenced by a
<source>tag is now correctly identified as being used and exported in apkgsEDIT: the added test is probably overkill