Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributing to open-source first time and contributed my part. #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mrjayantbokade
Copy link

@mrjayantbokade mrjayantbokade commented Dec 19, 2023

The changes made:

  1. Added one more tab in front of one, two, three digit tabs which will take string as a input and convert the characters to lowercase and if the length of String === 7 then it will call the success function
  2. There are some surprise custom input added by me that will create joy to the visitors if they are lucky
  3. like csk , thalla, ipl2024winner, mahi bhai, mahibhai, mahindrasinghdhoni, soham -> this is my friend who is mahi bhai's huge fan so "Thalla for A Reason"
  4. fixed the bug that you were facing on the single input tab . Where you wanted a single "try again " alert but it was displaying "hint : addition of numbers" was now fixed
  5. Additionally I added a second sound which will be played only for this new function
  6. Also I made some changes in CSS file for optimizations where( there is no default distance between tabs and the input box when switches between tabs and refresh pages )
  7. So that also I fixed that.

Hope you like it and merge it
This is my first Open-Source contribution
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant