feat: transfer error notification (#1460)

anoma · Jan 3, 2025 · 1945c61 · 1945c61 · github-actions · Jan 3, 2025
1 parent cb742eb
commit 1945c61
Show file tree

Hide file tree

Showing 3 changed files with 69 additions and 37 deletions.
diff --git a/apps/namadillo/package.json b/apps/namadillo/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@namada/namadillo",
-  "version": "1.1.7",
+  "version": "1.1.8",
   "description": "Namadillo",
   "repository": "https://github.com/anoma/namada-interface/",
   "author": "Heliax Dev <[email protected]>",

diff --git a/apps/namadillo/src/hooks/useTransactionNotifications.tsx b/apps/namadillo/src/hooks/useTransactionNotifications.tsx
@@ -11,7 +11,10 @@ import {
 import { searchAllStoredTxByHash } from "atoms/transactions";
 import BigNumber from "bignumber.js";
 import { useSetAtom } from "jotai";
-import { useTransactionEventListener } from "utils";
+import {
+  useTransactionEventListener,
+  useTransactionEventListListener,
+} from "utils";
 
 type TxWithAmount = { amount: BigNumber };
 
@@ -344,45 +347,70 @@ export const useTransactionNotifications = (): void => {
     });
   });
 
-  const handleTransferNotification = (
-    tx: TxProps,
-    data: TxWithAmount[]
-  ): void => {
-    const { id } = parseTxsData(tx, data);
-    clearPendingNotifications(id);
-    const storedTx = searchAllStoredTxByHash(tx.hash);
-    if (storedTx) {
+  useTransactionEventListListener(
+    [
+      "TransparentTransfer.Error",
+      "ShieldedTransfer.Error",
+      "ShieldingTransfer.Error",
+      "UnshieldingTransfer.Error",
+    ],
+    (e) => {
+      const tx = e.detail.tx;
+      const data: TxWithAmount[] = e.detail.data[0].data;
+      const { id } = parseTxsData(tx, data);
+      clearPendingNotifications(id);
+      const storedTx = searchAllStoredTxByHash(tx.hash);
+      dispatchNotification({
+        id,
+        type: "error",
+        title: "Transfer transaction failed",
+        description:
+          storedTx ?
+            <>
+              Your transfer transaction of{" "}
+              <TokenCurrency
+                symbol={storedTx.asset.symbol}
+                amount={storedTx.displayAmount}
+              />{" "}
+              to {shortenAddress(storedTx.destinationAddress, 8, 8)} has failed
+            </>
+          : "Your transfer transaction has failed",
+        details:
+          e.detail.error?.message && failureDetails(e.detail.error.message),
+      });
+    }
+  );
+
+  useTransactionEventListListener(
+    [
+      "TransparentTransfer.Success",
+      "ShieldedTransfer.Success",
+      "ShieldingTransfer.Success",
+      "UnshieldingTransfer.Success",
+    ],
+    (e) => {
+      const tx = e.detail.tx;
+      const data: TxWithAmount[] = e.detail.data[0].data;
+      const { id } = parseTxsData(tx, data);
+      clearPendingNotifications(id);
+      const storedTx = searchAllStoredTxByHash(tx.hash);
       dispatchNotification({
         id,
         title: "Transfer transaction succeeded",
-        description: (
-          <>
-            Your transfer transaction of{" "}
-            <TokenCurrency
-              symbol={storedTx.asset.symbol}
-              amount={storedTx.displayAmount}
-            />{" "}
-            to {shortenAddress(storedTx.destinationAddress, 8, 8)} has succeeded
-          </>
-        ),
+        description:
+          storedTx ?
+            <>
+              Your transfer transaction of{" "}
+              <TokenCurrency
+                symbol={storedTx.asset.symbol}
+                amount={storedTx.displayAmount}
+              />{" "}
+              to {shortenAddress(storedTx.destinationAddress, 8, 8)} has
+              succeeded
+            </>
+          : "Your transfer transaction has succeeded",
         type: "success",
       });
     }
-  };
-
-  useTransactionEventListener("TransparentTransfer.Success", (e) => {
-    handleTransferNotification(e.detail.tx, e.detail.data[0].data);
-  });
-
-  useTransactionEventListener("ShieldedTransfer.Success", (e) => {
-    handleTransferNotification(e.detail.tx, e.detail.data[0].data);
-  });
-
-  useTransactionEventListener("ShieldingTransfer.Success", (e) => {
-    handleTransferNotification(e.detail.tx, e.detail.data[0].data);
-  });
-
-  useTransactionEventListener("UnshieldingTransfer.Success", (e) => {
-    handleTransferNotification(e.detail.tx, e.detail.data[0].data);
-  });
+  );
 };
diff --git a/apps/namadillo/src/types/events.ts b/apps/namadillo/src/types/events.ts
@@ -60,9 +60,13 @@ declare global {
     "VoteProposal.Success": EventData<VoteProposalProps>;
     "VoteProposal.Error": EventData<VoteProposalProps>;
     "TransparentTransfer.Success": EventData<TransparentTransferProps>;
+    "TransparentTransfer.Error": EventData<TransparentTransferProps>;
     "ShieldedTransfer.Success": EventData<ShieldedTransferProps>;
+    "ShieldedTransfer.Error": EventData<ShieldedTransferProps>;
     "ShieldingTransfer.Success": EventData<ShieldingTransferProps>;
+    "ShieldingTransfer.Error": EventData<ShieldingTransferProps>;
     "UnshieldingTransfer.Success": EventData<UnshieldingTransferProps>;
+    "UnshieldingTransfer.Error": EventData<UnshieldingTransferProps>;
     "IbcTransfer.Success": EventData<IbcTransferProps>;
     "IbcTransfer.Error": EventData<IbcTransferProps>;
   }