-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: notify about needed account re import #1452
Conversation
.filter((account) => account.parentId) | ||
.map((account) => { | ||
const outdated = | ||
account.type !== AccountType.Ledger && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ignore ledger for now
}} | ||
/> | ||
))} | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I only wrapped everything in fragment to add Outlet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"p-5 pt-10" | ||
)} | ||
> | ||
<div |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of this was copied from namadillo's ModalContainer
😛
9222c5d
to
3a7dbe6
Compare
3a7dbe6
to
753529f
Compare
{alias} | ||
</label> | ||
<DropdownMenu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not change that, just wrapped in Stack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
To test, I downloaded the release version 0.3.6 and installed locally, on the same folder that the project builds /apps/extensions/build/chrome/
, then imported the key
After that, I switched to this branch, built the chrome extension, and run it. Then I was able to see the new flow
✅
}} | ||
/> | ||
))} | ||
<> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
closes #1430 |
Resolves #1440
Figma https://www.figma.com/design/NFyHbLZXBSl3aUsMxtffvV/Namada-End-User-Interface-V1.0-%2F-Phase-1%3A-Block-Party?node-id=9363-2665&t=x241erdmP130E13G-1
Testing