Namadillo: querying next rpc if the previous one fails #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
approved these changes
Jan 7, 2025
euharrison
reviewed
Jan 7, 2025
| // On error, saves the next available rpc | ||
| set(rpcByChainAtom, { | ||
| ...lastRpc, | ||
| [chain.chain_id]: getRpcByIndex(chain, rpc.index + 1), |
There was a problem hiding this comment.
Maybe in the future we could get from a random order. Loading all rpc urls into an atom and shuffling them. It could helps to don't have a bias for one or another rpc. But I see it is more work to do, so we can do it later
There was a problem hiding this comment.
We had that in the past, but we noticed that the first RPCs on the list were more reliable, so we switched to this solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we query an RPC endpoint and it fails for whatever reason (timeout, CORS, etc), we should query the next one in the list.
Closes #1464