fix: fixing gas estimate on IBC transfers #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
approved these changes
Feb 5, 2025
| @@ -132,14 +141,16 @@ export const TransferModule = ({ | |||
| return undefined; | |||
| } | |||
|
|
|||
| if (!gasConfig || gasConfig.gasToken !== selectedAssetAddress) { | |||
There was a problem hiding this comment.
The gasConfig.gasToken !== selectedAssetAddress is important because we can pay the gas with a different token and, if this is the case, we shouldn't subtract the gas from the availableAmount
| @@ -118,7 +115,7 @@ export const ShieldAllPanel = ({ | |||
| <Stack as="footer" gap={4}> | |||
| <footer className="flex justify-between items-center"> | |||
| <img src={ibcTransferImageBlack} className="w-20" /> | |||
| {gasConfig && <TransactionFee gasConfig={gasConfig} />} | |||
| {/*gasConfig && <TransactionFee gasConfig={gasConfig} />*/} | |||
There was a problem hiding this comment.
can we delete this and add a comment like // TODO add transaction fee?
| @@ -54,10 +54,12 @@ const useBuildGasOption = ({ | |||
| ...override, | |||
| }; | |||
|
|
|||
| const displayAmount = getDisplayGasFee(option); | |||
| const displayGasFee = getDisplayGasFee(option, chainAssetsMap); | |||
There was a problem hiding this comment.
Because of the uosmo address from two channels, we have an intermittent case of showing the osmo fee as zero
But probably something to handle in a different PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unit displayed and used to calculate if user has funds to make an IBC transfer.