Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update namada to 0.24.0 #416

Merged
merged 6 commits into from
Nov 2, 2023

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Oct 12, 2023

NOTE:
For some reason fetched wasm checksums are not correct :/
If you want to test this using e2e tests:

  • checkout namada 0.24.0
  • build namada and wasm scripts
  • copy to e2e/.namada
    • built namada binaries
    • checksums.json
    • wasm files to e2e/.namada/wasm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2023

@github-actions github-actions bot temporarily deployed to pull request October 12, 2023 12:43 Inactive
@emccorson emccorson force-pushed the sdk-refactor branch 2 times, most recently from 6d2c8f5 to 6e9b5ff Compare October 18, 2023 00:02
@mateuszjasiuk mateuszjasiuk changed the base branch from sdk-refactor to main October 18, 2023 08:06
@mateuszjasiuk mateuszjasiuk changed the base branch from main to sdk-refactor October 18, 2023 08:07
@mateuszjasiuk mateuszjasiuk changed the base branch from sdk-refactor to main October 18, 2023 08:10
@mateuszjasiuk mateuszjasiuk force-pushed the chore/update-namada-to-sdk-refactor branch 2 times, most recently from 827999a to b1eba77 Compare October 18, 2023 09:46
@github-actions github-actions bot temporarily deployed to pull request October 18, 2023 09:51 Inactive
@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review October 18, 2023 09:54
@mateuszjasiuk mateuszjasiuk changed the title WIP: update to sdk streamline refactor Point namada to "murisi/sdk-refactor-rebased" Oct 18, 2023
Copy link
Collaborator

@jurevans jurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mateuszjasiuk should we wait to merge this until those changes are in the next release? If it is blocking anything else, I think we could merge it sooner if needed.

@github-actions github-actions bot temporarily deployed to pull request October 26, 2023 12:27 Inactive
@mateuszjasiuk mateuszjasiuk changed the title Point namada to "murisi/sdk-refactor-rebased" chore: update namada to 0.24.0 Oct 26, 2023
Copy link
Contributor

@emccorson emccorson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and the transaction code is much cleaner now 👍

I think the CI is failing due to some naming error, and one minor comment, but everything looks good!

@@ -288,34 +287,17 @@ impl Sdk {
tx_msg: &[u8],
password: Option<String>,
xsk: Option<String>,
gas_payer: Option<String>
_gas_payer: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these gas_payer parameters can be completely removed now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can do it later, as there is a lot to do anyways :)

@mateuszjasiuk mateuszjasiuk force-pushed the chore/update-namada-to-sdk-refactor branch 2 times, most recently from 7de692d to 34bfb7d Compare November 2, 2023 09:27
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 09:31 Inactive
@mateuszjasiuk mateuszjasiuk force-pushed the chore/update-namada-to-sdk-refactor branch from 34bfb7d to fce6778 Compare November 2, 2023 09:43
@github-actions github-actions bot temporarily deployed to pull request November 2, 2023 09:48 Inactive
@mateuszjasiuk mateuszjasiuk merged commit 33b0e4a into main Nov 2, 2023
5 checks passed
@mateuszjasiuk mateuszjasiuk deleted the chore/update-namada-to-sdk-refactor branch September 13, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants