Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data fetching fixes #641

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Data fetching fixes #641

merged 5 commits into from
Mar 4, 2024

Conversation

emccorson
Copy link
Contributor

@emccorson emccorson commented Feb 21, 2024 •
edited
Loading

Changed

  • Use setter for fetching public keys to allow more control over when the fetch happens

Added

  • Add isConnected method and revoke event
  • Add effects to handle accounts changed, chain changed, extension attached, and extension connected. Replaces fetches interspersed in App and AccountOverview

Fixed

  • Fix balances race condition
  • Refresh public keys on Tx completed instead of toast change
  • Wait for shared to init before rendering app
  • Check for native token early in minimum gas price fetch
  • Remove unneeded optional chaining in useIntegration

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited
Loading

🚀 Deployed on https://pull-request-641--wallet-development-heliax-dev.netlify.app

@github-actions github-actions bot temporarily deployed to pull request February 21, 2024 06:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 21, 2024 07:00 Inactive
@emccorson emccorson force-pushed the fix/data-fetching-fixes branch from 1348e5a to bf75b18 Compare February 26, 2024 03:23
@github-actions github-actions bot temporarily deployed to pull request February 26, 2024 03:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 26, 2024 06:24 Inactive
emccorson added a commit that referenced this pull request Feb 29, 2024
@emccorson
fix: wait for shared to init before rendering app (#641)
2adccfb
emccorson added a commit that referenced this pull request Feb 29, 2024
@emccorson
feat: add isConnected method and revoke event (#641)
1ca4f13
emccorson added a commit that referenced this pull request Feb 29, 2024
@emccorson
fix: fix balances race condition (#641)
7e545ae
emccorson added a commit that referenced this pull request Feb 29, 2024
@emccorson
fix: add fetch effects and improve fetch behaviour (#641)
5c591e9 
- Add effects to handle accounts changed, chain changed, extension
  attached, and extension connected. Replaces fetches interspersed in
  App and AccountOverview

- Refresh public keys on Tx completed instead of toast change

- Use setter for fetching public keys to allow more control over when
  the fetch happens

- Check for native token early in minimum gas price fetch
emccorson added a commit that referenced this pull request Feb 29, 2024
@emccorson
fix: remove unneeded optional chaining (#641)
c6d6d1c
@emccorson emccorson force-pushed the fix/data-fetching-fixes branch from b7d753d to c6d6d1c Compare February 29, 2024 02:50
@emccorson emccorson changed the title Fix/data fetching fixes Data fetching fixes Feb 29, 2024
@github-actions github-actions bot temporarily deployed to pull request February 29, 2024 02:55 Inactive
@emccorson emccorson marked this pull request as ready for review February 29, 2024 03:09
mateuszjasiuk
mateuszjasiuk approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couldnt find any problems! :)

emccorson added 5 commits March 4, 2024 15:44
@emccorson
fix: wait for shared to init before rendering app (#641)
19d2ebf
@emccorson
feat: add isConnected method and revoke event (#641)
b505250
@emccorson
fix: fix balances race condition (#641)
1059477
@emccorson
fix: add fetch effects and improve fetch behaviour (#641)
dad5b77 
- Add effects to handle accounts changed, chain changed, extension
  attached, and extension connected. Replaces fetches interspersed in
  App and AccountOverview

- Refresh public keys on Tx completed instead of toast change

- Use setter for fetching public keys to allow more control over when
  the fetch happens

- Check for native token early in minimum gas price fetch
@emccorson
fix: remove unneeded optional chaining (#641)
11757a6
@emccorson emccorson force-pushed the fix/data-fetching-fixes branch from c6d6d1c to 11757a6 Compare March 4, 2024 06:44
@github-actions github-actions bot temporarily deployed to pull request March 4, 2024 06:54 Inactive
@emccorson emccorson merged commit 11757a6 into main Mar 4, 2024
8 checks passed
seleniumforest pushed a commit to seleniumforest/namada-interface that referenced this pull request Apr 11, 2024
@emccorson @seleniumforest
fix: wait for shared to init before rendering app (anoma#641)
efb4ab0
seleniumforest pushed a commit to seleniumforest/namada-interface that referenced this pull request Apr 11, 2024
@emccorson @seleniumforest
feat: add isConnected method and revoke event (anoma#641)
5ec9f74
seleniumforest pushed a commit to seleniumforest/namada-interface that referenced this pull request Apr 11, 2024
@emccorson @seleniumforest
fix: fix balances race condition (anoma#641)
5ac1a19
seleniumforest pushed a commit to seleniumforest/namada-interface that referenced this pull request Apr 11, 2024
@emccorson @seleniumforest
fix: add fetch effects and improve fetch behaviour (anoma#641)
27eb8d9 
- Add effects to handle accounts changed, chain changed, extension
  attached, and extension connected. Replaces fetches interspersed in
  App and AccountOverview

- Refresh public keys on Tx completed instead of toast change

- Use setter for fetching public keys to allow more control over when
  the fetch happens

- Check for native token early in minimum gas price fetch
seleniumforest pushed a commit to seleniumforest/namada-interface that referenced this pull request Apr 11, 2024
@emccorson @seleniumforest
fix: remove unneeded optional chaining (anoma#641)
f3d67c9
@mateuszjasiuk mateuszjasiuk deleted the fix/data-fetching-fixes branch September 13, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateuszjasiuk mateuszjasiuk mateuszjasiuk approved these changes

@jurevans jurevans Awaiting requested review from jurevans

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emccorson @mateuszjasiuk