Global Extension UI Review #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszjasiuk
approved these changes
Feb 28, 2024
storybook/src/components/Colour.tsx
Outdated
| description?: string; | ||
| }; | ||
|
|
||
| export const Colour = ({ |
There was a problem hiding this comment.
Total nitpick, not sure if valid. Does anyone have strong opinion about coding in british-english vs american-english? :D I feel like naming this color would be more consistent with tailwind
There was a problem hiding this comment.
Haha, I think this is an important decision we need to make. Because all the Extension texts are written in British-English, but the libraries, like Tailwind, are in American-English. I'll update the code in order to reflect your comment, @mateuszjasiuk !
pedrorezende
force-pushed
the
feat/extension-ui-1.1
branch
from
3949d1a to
222faae
Compare
pedrorezende
force-pushed
the
feat/extension-ui-1.1
branch
from
222faae to
8337ebb
Compare
seleniumforest
pushed a commit
to seleniumforest/namada-interface
that referenced
this pull request
Apr 11, 2024
* feat: adding cheatsheet to Storybook and Panel component * feat: tweaking button sizes and spacements * feat: ui tweaks on setup Start page * feat: adding div props to alert component * feat: reviewing warning panel and start page * feat: creating badge and feedback button components * feat: reducing sizes for seed phrase list * feat: finalizing seed creation review * feat: completing account creation flow review * feat: truncating addresses on confirmation * feat: few components ui review * feat: rolling back bip39 password input * feat: fixing ledger import * feat: fixing ledger forms alignment * feat: opening setup tab if no password is defined * feat: improving connected sites ui * feat: improving approve connections ui * feat: better alignment on signature popups * feat: few more ui tweaks on extension * feat: refactoring the copyTextTo property to make it more generic * fix: removing package-lock.json * feat: renaming colour to color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a full UI review in the whole extension, only missing dark / light mode implementation.
Changes were made based on this Figma board