Minor extension UI fixes #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emccorson
force-pushed
the
fix/minor-extension-ui-fixes
branch
from
0bdbe94 to
71383ff
Compare
emccorson
added a commit
that referenced
this pull request
Mar 5, 2024
The form contains two buttons and unless the type attribute is explicitly set, the default behaviour is type="submit" which means pressing the enter key clicks the first (and wrong) one.
emccorson
added a commit
that referenced
this pull request
Mar 5, 2024
emccorson
added a commit
that referenced
this pull request
Mar 5, 2024
emccorson
added a commit
that referenced
this pull request
Mar 5, 2024
emccorson
force-pushed
the
fix/minor-extension-ui-fixes
branch
from
22cdd0a to
e897e21
Compare
pedrorezende
approved these changes
Mar 5, 2024
| @@ -21,7 +24,7 @@ export const SeedPhraseWarning = ({ | |||
| if (countdown > 0) { | |||
| setCountdown((countdown) => countdown - 1); | |||
| } | |||
| }, 1000); | |||
| }, TIMEOUT); | |||
mateuszjasiuk
approved these changes
Mar 5, 2024
The form contains two buttons and unless the type attribute is explicitly set, the default behaviour is type="submit" which means pressing the enter key clicks the first (and wrong) one.
emccorson
force-pushed
the
fix/minor-extension-ui-fixes
branch
from
e897e21 to
de7b931
Compare
seleniumforest
pushed a commit
to seleniumforest/namada-interface
that referenced
this pull request
Apr 11, 2024
The form contains two buttons and unless the type attribute is explicitly set, the default behaviour is type="submit" which means pressing the enter key clicks the first (and wrong) one.
seleniumforest
pushed a commit
to seleniumforest/namada-interface
that referenced
this pull request
Apr 11, 2024
seleniumforest
pushed a commit
to seleniumforest/namada-interface
that referenced
this pull request
Apr 11, 2024
seleniumforest
pushed a commit
to seleniumforest/namada-interface
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Changed
Progress indicator before:
After: