V2.0 #104
Merged
V2.0 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to use > phpunit 10.0, as the breaking changes in there stopped us going higher on the test framework meaning that we couldn't support testing supported versions of Laravel. There are still test deprecations on here, but I'll deal with these at a later date
I'm anticipating standards being added to CI
This will allow us to run tests on the currently supported Laravel versions in CI
This will let us test v2 in CI. I will reomve this before the PR to master
I shouldn't have committed this
This is a bash command, not PHP
This is needed to drop support for < Laravel/Lumen 10
I would like my changes to go through the standard test flow
…ort-only-supported-laravel
This should let composer complete
CI was failing on Laravel 10 with PHP 8.2, the require coimmand will do an install for us
The require does an install for us
We will no longer get warnings when tests run. I also took the opportunity to move these to camel case from snake case so it aligns more with PSR standards
This helps to make the cvode stricter and let the IDE know what is going on
Support only supported laravel
Remove phpunit deprecations
This brings stricter coding
This now matches other checks
This will make behaviour more consistent and allow IDE typehinting/error detection
Add strict typing
Swap sensiolabs/security-checker for enlightn/security-checker as the sensiolabs one is now abandoned. Co-authored-by: Steve Richter <[email protected]>
Very minor updates to make the code a bit cleaner
This was me commiting test code by accident
We now have all the suggested packages
Fix package security check
This can now use the latest verisons
This wil not be allowed when CI checks standards
This can now include `Error`s
Fix ftp check
This will allow me to make future additional CI jobs more sucinct
We can start tipdying the code thanks to static analysis
These checks basic checks, unknown classes, unknown functions, unknown methods called on $this, wrong number of arguments passed to those methods and functions, always undefined variables
Add larastan
There were no changes for level 1, so I've moved to level 2 and fixed the code for that. Level 1: possibly undefined variables, unknown magic methods and properties on classes with __call and __get Level 2: unknown methods checked on all expressions (not just $this), validating PHPDocs
…eck into add-larastan
Bump Larastan to level 2
THis is the next level bump for Larastan. Level 3: return types, types assigned to properties
Bump to Larastan level 3
This is the next Larastan bump. Level 4: Basic dead code checking - always false instanceof and other type checks, dead else branches, unreachable code after return; etc.
Larastan has reminded me it is good to be explicit
We can allow test files to not be included in this as is the nature of tests. "with" is also usd as a setter, so we can keep that out too
Bump Larastan to level 4
This is the next Larastan bump. Level 5: Checking types of arguments passed to methods and functions
Bump Larastan to level 5
This is the next & final (at least for now) Larastan bump. Level 6: report missing typehints
This will now pass CI, good suggestions
This will enforce the new coding standard
The optional depedencies in here add a layer of complexity which we don't want to handle
Bump Larastan to level 6
This covers the new tooling we've introduced in v2
Update the contributing notes
This is the list of changes we'll be including in v2
Add v2 features into the changelog
This is indented to match the rest of the code
This offers more context to a first time reader
It will always be 1 as it is 1 object, we neede the array from this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling the v2.0 branch into the main branch in order to release v2.0.
Please have a critique.
#86