Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance secure_backup property is readonly #165

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Instance secure_backup property is readonly #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/service/ecloud/request.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@
VolumeIOPS int `json:"volume_iops,omitempty"`
BackupEnabled bool `json:"backup_enabled"`
BackupGatewayID string `json:"backup_gateway_id,omitempty"`
BackupAgentEnabled bool `json:"secure_backup,omitempty"` // XXX: This will change in the future to `backup_agent_enabled`, see ADO#34659
IsEncrypted bool `json:"is_encrypted"`
NetworkID string `json:"network_id,omitempty"`
FloatingIPID string `json:"floating_ip_id,omitempty"`
Expand All @@ -268,6 +267,7 @@
VCPUCoresPerSocket int `json:"vcpu_cores_per_socket,omitempty"`
RAMCapacity int `json:"ram_capacity,omitempty"`
VolumeGroupID *string `json:"volume_group_id,omitempty"`
BackupGatewayID string `json:"backup_gateway_id,omitempty"`
}

// CreateFirewallPolicyRequest represents a request to create a firewall policy
Expand Down Expand Up @@ -546,7 +546,7 @@
NetworkID string `json:"network_id"`
}

// CreateLoadBalancerRequest represents a request to patch a load balancer

Check notice on line 549 in pkg/service/ecloud/request.go

View workflow job for this annotation

GitHub Actions / Qodana for Go

Comment of exported element starts with the incorrect name 

Comment should have the following format 'PatchLoadBalancerRequest ...' (with an optional leading article)
type PatchLoadBalancerRequest struct {
Name string `json:"name,omitempty"`
}
Expand Down Expand Up @@ -617,7 +617,7 @@
Description string `json:"description,omitempty"`
}

// NATOverloadRule represents an eCloud NAT overload rule

Check notice on line 620 in pkg/service/ecloud/request.go

View workflow job for this annotation

GitHub Actions / Qodana for Go

Comment of exported element starts with the incorrect name 

Comment should have the following format 'CreateNATOverloadRuleRequest ...' (with an optional leading article)
type CreateNATOverloadRuleRequest struct {
Name string `json:"name,omitempty"`
NetworkID string `json:"network_id"`
Expand All @@ -626,7 +626,7 @@
Action NATOverloadRuleAction `json:"action"`
}

// NATOverloadRule represents an eCloud NAT overload rule

Check notice on line 629 in pkg/service/ecloud/request.go

View workflow job for this annotation

GitHub Actions / Qodana for Go

Comment of exported element starts with the incorrect name 

Comment should have the following format 'PatchNATOverloadRuleRequest ...' (with an optional leading article)
type PatchNATOverloadRuleRequest struct {
Name string `json:"name,omitempty"`
Subnet string `json:"subnet,omitempty"`
Expand Down
Loading