-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the Config aggregator module #1830
base: main
Are you sure you want to change the base?
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: You can compare to the docs for the File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/config_aggregator_module.html b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/config_aggregator_module.html
index 6542619..2f20205 100644
--- a/home/runner/work/community.aws/community.aws/docsbuild/base/collections/community/aws/config_aggregator_module.html
+++ b/home/runner/work/community.aws/community.aws/docsbuild/head/collections/community/aws/config_aggregator_module.html
@@ -195,7 +195,7 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
</tr>
<tr class="row-odd"><td><div class="ansible-option-cell">
<div class="ansibleOptionAnchor" id="parameter-account_sources"></div><p class="ansible-option-title" id="ansible-collections-community-aws-config-aggregator-module-parameter-account-sources"><strong>account_sources</strong></p>
-<a class="ansibleOptionLink" href="#parameter-account_sources" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">list</span> / <span class="ansible-option-elements">elements=dictionary</span> / <span class="ansible-option-required">required</span></p>
+<a class="ansibleOptionLink" href="#parameter-account_sources" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">list</span> / <span class="ansible-option-elements">elements=dictionary</span></p>
</div></td>
<td><div class="ansible-option-cell"><p>Provides a list of source accounts and regions to be aggregated.</p>
</div></td>
@@ -278,7 +278,7 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
</tr>
<tr class="row-even"><td><div class="ansible-option-cell">
<div class="ansibleOptionAnchor" id="parameter-organization_source"></div><p class="ansible-option-title" id="ansible-collections-community-aws-config-aggregator-module-parameter-organization-source"><strong>organization_source</strong></p>
-<a class="ansibleOptionLink" href="#parameter-organization_source" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">dictionary</span> / <span class="ansible-option-required">required</span></p>
+<a class="ansibleOptionLink" href="#parameter-organization_source" title="Permalink to this option"></a><p class="ansible-option-type-line"><span class="ansible-option-type">dictionary</span></p>
</div></td>
<td><div class="ansible-option-cell"><p>The region authorized to collect aggregated data.</p>
</div></td>
@@ -416,11 +416,18 @@ see <a class="reference internal" href="#ansible-collections-community-aws-confi
<span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">test_config_rule</span>
<span class="w"> </span><span class="nt">state</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">present</span>
<span class="w"> </span><span class="nt">account_sources</span><span class="p">:</span>
-<span class="w"> </span><span class="nt">account_ids</span><span class="p">:</span>
-<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">1234567890</span>
-<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">0123456789</span>
-<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">9012345678</span>
-<span class="w"> </span><span class="nt">all_aws_regions</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">true</span>
+<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">all_aws_regions</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">true</span>
+<span class="w"> </span><span class="nt">account_ids</span><span class="p">:</span>
+<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">1234567890</span>
+<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">0123456789</span>
+<span class="w"> </span><span class="p p-Indicator">-</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">9012345678</span>
+
+<span class="p p-Indicator">-</span><span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">Create organization aggregator</span>
+<span class="w"> </span><span class="nt">community.aws.config_aggregator</span><span class="p">:</span>
+<span class="w"> </span><span class="nt">name</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">organization_aggregator</span>
+<span class="w"> </span><span class="nt">state</span><span class="p">:</span><span class="w"> </span><span class="l l-Scalar l-Scalar-Plain">present</span>
+<span class="w"> </span><span class="nt">organization_source</span><span class="p">:</span>
+<span class="w"> </span><span class="nt">role_arn</span><span class="p">:</span><span class="w"> </span><span class="s">"arn:aws:iam::012345678910:role/AWSConfigRole"</span>
</pre></div>
</div>
<section id="authors">
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 17s |
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 13s |
Build succeeded. ❌ ansible-galaxy-importer FAILURE in 5m 19s (non-voting) |
SUMMARY
The current
aws_config_aggregator
module has bothaccount_sources
andorganization_source
parameters listed as required.However, the Config service API doesn't have any of these two parameters as required. This is because we can either configure an aggregator against a list of accounts or against all accounts in an organization.
This fix allows us to chose which parameters to pass instead of having to pass both.
ISSUE TYPE
COMPONENT NAME
aws_config_aggregator