Implement the Global Accelerator create/update module #97
Conversation
| return accelerator | ||
|
|
||
|
|
||
| class GlobalAccelerator(object): |
There was a problem hiding this comment.
TBH I'm mad confused about where the various files for this repo live. Based on other modules here, it seems like this class should live somewhere else. I'm happy to move it if someone can point me in a direction
There was a problem hiding this comment.
Is this class needed for this module? These methods should be able to be moved into the module and called from main() based on the action the user is requesting.
TylerLubeck
changed the title
ansibullbot
added
affects_2.10
module
jillr
added
the
pr_day
There was a problem hiding this comment.
Thanks for this new module PR @TylerLubeck. This will need an integration test suite to be added at test/integration/global_accelerator, which will likely also need IAM policies added for our CI.
| return accelerator | ||
|
|
||
|
|
||
| class GlobalAccelerator(object): |
There was a problem hiding this comment.
Is this class needed for this module? These methods should be able to be moved into the module and called from main() based on the action the user is requesting.
* add FQCN to M() references * add missing one
tremble
removed
the
pr_day
SUMMARY
Implement the Global Accelerator create/update module for #94
This is largely modeled after the
elb_application_lbmoduleISSUE TYPE
COMPONENT NAME
global_accelerator