-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nmcli): remove bond from ip_conn_type #8729
base: main
Are you sure you want to change the base?
fix(nmcli): remove bond from ip_conn_type #8729
Conversation
By `bond` connections being included in the `ip_conn_type` list, the resulting `nmcli` commands include references to `ipv4` and `ipv6` settings. These options are not available to `bond` connection types as stated by the error output in issue ansible-collections#8558. Closes ansible-collections#8558
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
@@ -0,0 +1,2 @@ | |||
minor_changes: | |||
- "nmcli - corrects underlying command formation by no longer including ``ipv4.*`` and ``ipv6.*`` settings when working with ``bond`` connection types (https://github.com/ansible-collections/community.general/issues/8558)." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- "nmcli - corrects underlying command formation by no longer including ``ipv4.*`` and ``ipv6.*`` settings when working with ``bond`` connection types (https://github.com/ansible-collections/community.general/issues/8558)." | |
- "nmcli - corrects underlying command formation by no longer including ``ipv4.*`` and ``ipv6.*`` settings when working with ``bond`` connection types (https://github.com/ansible-collections/community.general/issues/8558, https://github.com/ansible-collections/community.general/pull/8729)." |
It seems like this was different in the past, since at least some ipv4/ipv6 settings were intentionally passed on for |
Thanks for the feedback. I have marked this as a draft. This is looking/feeling more like a workflow problem instead of requiring the solution I proposed. Following a process such as the one described here results in |
So regarding issue #8558, you think it can be resolved by refactoring the steps in the playbook? |
SUMMARY
Removes
bond
connection types from theip_conn_type
list. Currently, withbond
connections being included in theip_conn_type
list, the resultingnmcli
commands include references toipv4
andipv6
settings. These options are not available tobond
connection types as stated by the error output in issue #8558.Fixes #8558
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
nmcli
ADDITIONAL INFORMATION