Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SR-IOV support to nmcli module #9168

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add SR-IOV support to nmcli module #9168

wants to merge 8 commits into from

Conversation

ianb-mp
Copy link

@ianb-mp ianb-mp commented Nov 20, 2024

SUMMARY

Allow the SR-IOV settings documented here to be configured via Ansible nmcli module: https://networkmanager.pages.freedesktop.org/NetworkManager/NetworkManager/settings-sriov.html

Closes #9122

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

nmcli

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) labels Nov 20, 2024
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
0f1be4d 
Fixes
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
16990c3 
Fixes
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
3b2e569 
Fixes
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI tests tests unit tests/unit and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Nov 21, 2024
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
26f4597 
Add test
@ansibullbot

This comment was marked as outdated.

Sign in to view
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
5b45be8
@ansibullbot

This comment was marked as outdated.

Sign in to view
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
89391fd
ianb-mp added a commit to ianb-mp/community.general that referenced this pull request Nov 21, 2024
@ianb-mp
Add SR-IOV support to nmcli module (ansible-collections#9168)
ec971c9
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Nov 21, 2024
@ianb-mp
Copy link
Author

ianb-mp commented Nov 21, 2024 •
edited
Loading

All lint checks are passing, but I was unable to make the unit test work. I've run out of time unfortunately. Hopefully someone else can spot the problem.

@ianb-mp ianb-mp marked this pull request as ready for review November 21, 2024 04:26
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed WIP Work in progress needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Nov 21, 2024
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-10 Automatically create a backport for the stable-10 branch labels Nov 21, 2024
felixfontein
felixfontein reviewed Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I've added some first comments below.

changelogs/fragments/9168-nmcli-add-sriov-parameter.yml Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
plugins/modules/nmcli.py Outdated Show resolved Hide resolved
@ianb-mp
Copy link
Author

ianb-mp commented Nov 24, 2024 •
edited
Loading

hello @felixfontein , fyi I add the changes you suggested and also fixed the failing CI. I tested this change on a host with SR-IOV interface, and it worked as expected.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-10 Automatically create a backport for the stable-10 branch check-before-release PR will be looked at again shortly before release and merged if possible. feature This issue/PR relates to a feature request module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SR-IOV support to nmcli module
3 participants
@ianb-mp @ansibullbot @felixfontein