test helper: improvements #9672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - methods `from_module()`, `from_file()` and `from_spec()` now all have a similar order of parameters - `from_module()` tries extensions `.yaml` and `.yml` before giving up - remove redundant parameter `test_spec` from `from_module()` - `from_file()` now receives an open, readable, file handle instead of a filename - `Helper` no longer accepts a test specification that is a top-level list of testcases, it must be a dict containing the key `test_cases`, which will be the list. - test_snap.py adjusted for the change in `from_spec()`
|
The test |
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
felixfontein
approved these changes
Feb 2, 2025
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9673 🤖 @patchback |
felixfontein
removed
the
check-before-release
patchback bot
pushed a commit
that referenced
this pull request
Feb 2, 2025
(cherry picked from commit 7a6125b)
felixfontein
pushed a commit
that referenced
this pull request
Feb 2, 2025
) test helper: improvements (#9672) (cherry picked from commit 7a6125b) Co-authored-by: Alexei Znamensky <[email protected]>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
from_module(),from_file()andfrom_spec()now all have a similar order of parametersfrom_module()tries extensions.yamland.ymlbefore giving uptest_specfromfrom_module()from_file()now receives an open, readable, file handle instead of a filenameHelperno longer accepts a test specification that is a top-level list of testcases, it must be a dict containing the keytest_cases, which will be the list.from_spec()SUMMARY
ISSUE TYPE
COMPONENT NAME
tests/unit/plugins/modules/helper.py
tests/unit/plugins/modules/test_snap.py