[mysql_db] Fix wrong documentation about pipefail #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andersson007
approved these changes
Nov 14, 2024
laurent-indermuehle
merged commit d613fa1
into
ansible-collections:main
55 checks passed
laurent-indermuehle
deleted the
lie_document_pipefail_is_for_dump_not_import
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
pipefail currently only works with mysqldump (
state=dump), not while importing a dump. I know this because it's me that added that feature.I'm wondering if a corrupted dump could also yield no errors when importing it using
mysql_db. What do you guys think? Should I implement this option also forstate=import?I'm hesitant because I don't understand those lines: https://github.com/ansible-collections/community.mysql/blob/main/plugins/modules/mysql_db.py#L533-L553
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION