This repository has been archived by the owner on May 28, 2024. It is now read-only.
Update checklist for post-inclusion recommendations #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found this older issue so opening a PR so we can discuss... Fixes ansible-community/community-team#100
| - [ ] Subscribe to the [news-for-maintainers](https://github.com/ansible-collections/news-for-maintainers) repo and track announcements there. | ||
| - [ ] Optionally but highly recommended, subscribe to the [Ansible Bullhorn](https://github.com/ansible/community/wiki/News#the-bullhorn). You can also post in the Bullhorn for community feedback or for important announcements such new releases of this collection. | ||
| - [ ] Review the [Maintainer guidelines](https://github.com/ansible/community-docs/blob/main/maintaining.rst). | ||
| - [ ] Optionally, share the above with future maintainers, in a README on CONTRIBUTING file in the collection repo. |
There was a problem hiding this comment.
I don't think this should be part of this checklist. This checklist is for reviewing only so far. Maybe we should add this as a separate file?
There was a problem hiding this comment.
- Adding as a separate file as @felixfontein suggested SGMT. I think it's worth to put a link to the end of the checklist as a reminder for reviewers to mention it as it's important
- I wouldn't include the news-for-maintainers at least now
- All the other links should be updated
| @@ -54,3 +54,10 @@ Note for reviewers: If you don't know how to check the points below, please ask | |||
| - [ ] all CI tests MUST run against every pull request | |||
| - [ ] all CI tests MUST run regularly (nightly, or at least once per week) | |||
| - [ ] sanity tests MUST run against a commit that releases the collection; if they don't pass, the collection won't be released | |||
|
|
|||
| **Steps to complete after inclusion is approved** | |||
There was a problem hiding this comment.
Added couple of points, thanks for pinging!
|
the doc has been moved to https://github.com/ansible-collections/ansible-inclusion/blob/main/collection_checklist.md, could you please re-create the PR there? Closing this one, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this older issue so opening a PR so we can discuss...
Fixes ansible-community/community-team#100