Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CLI handling to reduce code duplication and reuse framework for topics, userscram and ACL #103

Merged
merged 5 commits into from
Nov 22, 2023
Merged

Refactor CLI handling to reduce code duplication and reuse framework for topics, userscram and ACL #103

merged 5 commits into from
Nov 22, 2023

Conversation

rpelisse
Copy link
Collaborator

@rpelisse rpelisse commented Nov 21, 2023 •
edited
Loading

Fixes #64 .

@rpelisse rpelisse requested a review from rmarting November 21, 2023 08:10
@rpelisse rpelisse self-assigned this Nov 21, 2023
@rpelisse rpelisse added minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix enhancement New feature or request labels Nov 21, 2023
@rpelisse rpelisse mentioned this pull request Nov 21, 2023
Closed
rmarting
rmarting suggested changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing the definition of the new variables in the documentation. The rest of the PR LGTM.

@rpelisse
Copy link
Collaborator Author

@rmarting Good catch about the documentation! I actually want to update the docs everywhere, as we still have a lot of TODO in the description of the variables. So, I'll go ahead and merge this PR, but another one, with documentation update will come soon!

@rpelisse rpelisse merged commit f04048a into main Nov 22, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarting rmarting rmarting requested changes

Assignees

@rpelisse rpelisse

Labels
enhancement New feature or request minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enabling Simple authorizer to manage ACL rules
2 participants
@rpelisse @rmarting