Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup validation logic for offline install #89

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fixup validation logic for offline install #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
617cdc6
Fixup validation logic for offline install
rpelisse Sep 28, 2023
f443537
lint: warn for meta-runtime[unsupported-versions]
rpelisse Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .ansible-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ warn_list:
- key-order[task]
- schema[tasks]
- name[missing]
- meta-runtime[unsupported-version]

skip_list:
- vars_should_not_be_used
Expand Down
2 changes: 1 addition & 1 deletion galaxy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
namespace: middleware_automation
name: amq_streams
version: "0.0.6"
version: "0.0.7"

Check warning on line 4 in galaxy.yml

View workflow job for this annotation

GitHub Actions / ci / linter (3.11, 2.15)

galaxy[version-incorrect] 

collection version should be greater than or equal to 1.0.0
readme: README.md
authors:
- Romain Pelisse <[email protected]>
Expand Down
2 changes: 1 addition & 1 deletion roles/amq_streams_common/tasks/install.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
- name: Validate existing zipfiles for offline installs
ansible.builtin.assert:
that:
- amq_streams_common_version is defined and amq_streams_common_path_to_archive_file is exists
- amq_streams_common_path_to_archive_file is exists
quiet: True
fail_msg: "An offline install was requested, but files are not present on the controller: {{ amq_streams_common_path_to_archive_file }}"
when:
Expand Down
Loading