Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a wait stmt to allow user to wait for Zookeeper to be active, before starting broker #94

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add a wait stmt to allow user to wait for Zookeeper to be active, before starting broker #94

merged 1 commit into from
Oct 10, 2023

Conversation

rpelisse
Copy link
Collaborator

@rpelisse rpelisse commented Oct 5, 2023 •
edited
Loading

Issue: #83

@rpelisse rpelisse mentioned this pull request Oct 5, 2023
Closed
@rpelisse rpelisse self-assigned this Oct 5, 2023
@rpelisse rpelisse added enhancement New feature or request minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix labels Oct 5, 2023
@rpelisse
Copy link
Collaborator Author

@rmarting for the sake of peer-review, can you review and approve this PR? Thanks! :)

rmarting
rmarting approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@rmarting rmarting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rpelisse rpelisse merged commit 77c4577 into main Oct 10, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarting rmarting rmarting approved these changes

Assignees

@rpelisse rpelisse

Labels
enhancement New feature or request minor_changes New parameters added to modules, or non-breaking behavior changes to existing parameters; no bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpelisse @rmarting