Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs builds are failing with sphinx v7 #327

Closed
gotmax23 opened this issue Aug 23, 2023 · 4 comments
Closed

Docs builds are failing with sphinx v7 #327

gotmax23 opened this issue Aug 23, 2023 · 4 comments
Labels
doc builds Relates to building the documentation

Comments

@gotmax23
Copy link
Collaborator 

08:20:44  sphinx-build -M html "rst" "_build" -j 3 -n -w rst_warnings -c "rst"  
08:20:44  Running Sphinx v7.2.2
08:20:44  
08:20:44  Exception occurred:
08:20:44    File "/usr/local/lib/python3.10/site-packages/notfound/extension.py", line 337, in setup
08:20:44      from sphinx.builders.html import setup_js_tag_helper
08:20:44  ImportError: cannot import name 'setup_js_tag_helper' from 'sphinx.builders.html' (/usr/local/lib/python3.10/site-packages/sphinx/builders/html/__init__.py)

we should pin sphinx to sphinx < 7 in https://github.com/ansible/ansible-documentation/blob/devel/tests/constraints-base.in and investigate the issue.
@github-actions github-actions bot added the needs_triage Needs a first human triage before being processed. label Aug 23, 2023
@gotmax23 gotmax23 added doc builds Relates to building the documentation needs_triage Needs a first human triage before being processed. and removed needs_triage Needs a first human triage before being processed. labels Aug 23, 2023
@oraNod oraNod removed the needs_triage Needs a first human triage before being processed. label Aug 23, 2023
@oraNod
Copy link
Contributor

oraNod commented Aug 23, 2023

@gotmax23 FYI sphinx-doc/sphinx#11633

@oraNod
Copy link
Contributor

oraNod commented Aug 23, 2023

Actually this is the one: readthedocs/sphinx-notfound-page#219

@stevenjorgensen67
Copy link

As noted it sphinx-doc/sphinx#11633 this works in version 7.1.2

gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Aug 23, 2023
@gotmax23
limit sphinx to < 7.2.0 in requirements-relaxed
f794e0d 
Relates: ansible#327
@gotmax23 gotmax23 mentioned this issue Aug 23, 2023
Merged
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Aug 23, 2023
@gotmax23
limit sphinx to < 7.2.0 in requirements-relaxed
64fe0ba 
7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint
that applies to the testing requirements (requirements-relaxed).

Relates: ansible#327
oraNod pushed a commit that referenced this issue Aug 24, 2023
@gotmax23
limit sphinx to < 7.2.0 in requirements-relaxed (#329)
c07047f 
7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint
that applies to the testing requirements (requirements-relaxed).

Relates: #327
gotmax23 added a commit to gotmax23/ansible-documentation that referenced this issue Aug 27, 2023
@gotmax23
limit sphinx to < 7.2.0 in requirements-relaxed (ansible#329)
a6c095d 
7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint
that applies to the testing requirements (requirements-relaxed).

(cherry picked from commit c07047f)

Relates: ansible#327
@gotmax23
Copy link
Collaborator Author

Fixed in #365.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc builds Relates to building the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gotmax23 @oraNod @stevenjorgensen67