limit sphinx to < 7.2.0 in requirements-relaxed
#329
Conversation
github-actions
bot
added
the
needs_triage
|
Rebased to fix commit message |
These PRs address separate issues. This PR sets a general constraint that applies to the testing requirements (requirements-relaxed). Adding an exact pin for the sphinx version is a separate issue and handled by @oraNod's PR. The two PRs are additive, not mutually exclusive.
Yeah, even though the relaxed requirements file is not used for production docs builds, it'd still be a good idea to make sure the build works on testing. |
|
Ok thanks. Is there an order in which these PRs should merge or does it not matter? |
7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint that applies to the testing requirements (requirements-relaxed). Relates: ansible#327
It doesn't matter, but I would merge this one first. I changed it a bit so all it does is set a general constraint and not update lock files at all. Therefore, it shouldn't affect docs builds at all, as they have a specific sphinx version pinned. I also added some PR body text. Thanks for the suggestion. |
samccann
removed
the
needs_triage
|
Thanks @gotmax23 and all |
7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint that applies to the testing requirements (requirements-relaxed). (cherry picked from commit c07047f) Relates: ansible#327
Reverts "limit sphinx to `< 7.2.0` in requirements-relaxed (ansible#329)" The new version of sphinx-not-found-page restores compatibility with newer sphinx versions, so we no longer need to limit it. Note that this only affects the requirements-relaxed file used for local testing. Production builds still use `sphinx==6.2.1` Ref: ansible#351 (comment)
Reverts "limit sphinx to `< 7.2.0` in requirements-relaxed (ansible#329)" The new version of sphinx-not-found-page restores compatibility with newer sphinx versions, so we no longer need to limit it. Note that this only affects the requirements-relaxed file used for local testing. Production builds still use `sphinx==6.2.1` Ref: ansible#351 (comment)
Reverts "limit sphinx to `< 7.2.0` in requirements-relaxed (ansible#329)" The new version of sphinx-not-found-page restores compatibility with newer sphinx versions, so we no longer need to limit it in constraints-base.in The production `requirements.txt` file will be constrained to `sphinx == 7.2.5` until we manually change the pin in constraints.in. The requirements-relaxed.txt file for local testing will continue updating to the latest sphinx version in the weekly requirements update PRs. Ref: ansible#351 (comment)
Reverts "limit sphinx to `< 7.2.0` in requirements-relaxed (#329)" The new version of sphinx-not-found-page restores compatibility with newer sphinx versions, so we no longer need to limit it in constraints-base.in The production `requirements.txt` file will be constrained to `sphinx == 7.2.5` until we manually change the pin in constraints.in. The requirements-relaxed.txt file for local testing will continue updating to the latest sphinx version in the weekly requirements update PRs. Ref: #351 (comment)
limit sphinx to
< 7.2.0in requirements-relaxed7.2.0 breaks sphinx-notfound-page. This commit sets a general constraint
that applies to the testing requirements (requirements-relaxed).
Relates: #327