Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate specified inventory files #4393

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cavcrosby
Copy link
Contributor

@cavcrosby cavcrosby commented Nov 9, 2024

Fixes: #4241 #4225

@cavcrosby cavcrosby requested a review from a team as a code owner November 9, 2024 23:53
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from a5e6c76 to 7595e5f Compare November 10, 2024 00:24
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 7595e5f to cfedf17 Compare November 10, 2024 00:32
@abhikdps abhikdps added the bug label Nov 10, 2024
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from cfedf17 to 9a5e309 Compare November 10, 2024 20:47
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 9a5e309 to e5eac53 Compare November 11, 2024 15:14
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from e5eac53 to c5bf8c5 Compare November 12, 2024 23:51
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from c5bf8c5 to 5f56898 Compare November 14, 2024 00:43
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 5f56898 to ee4cf85 Compare November 15, 2024 23:35
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from ee4cf85 to f9e104a Compare November 16, 2024 15:14
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from f92d14d to c8e4e98 Compare November 22, 2024 14:21
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from c8e4e98 to 12c1678 Compare November 24, 2024 23:17
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 12c1678 to 33abe4a Compare November 25, 2024 14:28
@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 33abe4a to a277b07 Compare November 26, 2024 14:05
The ansible_cfg_inventory conditional in the _get_inventory_files method
is used because otherwise, when not passing in an inventory file via
CLI, inventory_files would set to the /etc/ansible/hosts (the default
value for the DEFAULT_HOST_LIST config). In most cases, I'd presume that
wouldn't be desired.
auto-merge was automatically disabled December 6, 2024 14:25

Head branch was pushed to by a user without write access

@cavcrosby cavcrosby force-pushed the add-inventory-option branch from 9985693 to 48c1440 Compare December 6, 2024 14:25
@ssbarnea ssbarnea enabled auto-merge (squash) December 6, 2024 14:34
@ssbarnea ssbarnea merged commit 6fbb12e into ansible:main Dec 6, 2024
29 checks passed
@cavcrosby cavcrosby deleted the add-inventory-option branch December 6, 2024 16:40
ssbarnea added a commit that referenced this pull request Dec 12, 2024
This reverts commit 6fbb12e.
This reverts commit 4d295e8.

Fixes: #4448
Fixes: #4449
ssbarnea added a commit that referenced this pull request Dec 12, 2024
This reverts commit 6fbb12e.
This reverts commit 4d295e8.

Fixes: #4448
Fixes: #4449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Variable groups: 'dict object' has no attribute '{group_name}' - syntax-check[specific]
3 participants