PR to push implementation Inline replace functionality from ARI #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
ansible_risk_insight/finder.py
Outdated
| logging.basicConfig( | ||
| level=os.environ.get('LOGLEVEL', 'WARNING').upper() | ||
| ) | ||
|
|
There was a problem hiding this comment.
ARI already has its own logger at ansible_risk_insight.logger and we can use it like this, so please consider using it instead of the native logging library.
If the native logging is better here, we can accept this change, but at least the environment variable should be consistent with the existing one ARI_LOG_LEVEL (ref: link)
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
hirokuni-kitahara
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to push implementation Inline replace functionality from ARI.
Currently the
--fixoperation is supported/enabled with--scan-per-targetcommand.Steps to test:
ari project <local github repository> --out-dir /tmp/test --save-only-rule-result --scan-per-target --task-num-threshold 100 --fix