Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make callback event_dict fields consitent #1005

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

valbendan
Copy link

add name field to event_dict to make callback event_dict fields more consitent (intended to fix missing name field)

@valbendan valbendan requested a review from a team as a code owner February 18, 2022 13:59
@valbendan valbendan changed the title make callback event_dict consitent make callback event_dict fields consitent Feb 18, 2022
@AlanCoding
Copy link
Member

Without more information, I'm hesitant about merging this diff. What consistency does this add? Other cases we use name includes this, which is the play name.

name = play.get_name().strip() or pattern
event_data = dict(
name=name,

I do see other cases where we put in the task name, but all of those cases look rather duplicated with the task key. For a problem that like, I would prefer to put up a notice to deprecate the ambiguous field in favor of the other field.

@Akasurde
Copy link
Member

@valbendan Could you please address the #1005 (comment)? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants