Enable kebab dropdown keyboard accessibility #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AWX
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
6 times, most recently
from
da263c9 to
9d4ee10
Compare
jamestalton
requested changes
Jun 21, 2024
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
from
9d4ee10 to
afd9c9e
Compare
marshmalien
requested review from
akus062381,
vishsanghishetty,
AlexSCorey,
vidyanambiar,
keithjgrant,
lgalis,
ZitaNemeckova and
kialam
as code owners
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
7 times, most recently
from
0362654 to
63372f6
Compare
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
3 times, most recently
from
0657954 to
b3cbcf8
Compare
jamestalton
previously approved these changes
Jul 15, 2024
nixocio
previously approved these changes
Jul 16, 2024
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
2 times, most recently
from
f687729 to
0a62b90
Compare
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
7 times, most recently
from
880836c to
887107e
Compare
nixocio
approved these changes
Jul 23, 2024
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
from
887107e to
c785e9b
Compare
keithjgrant
approved these changes
Jul 23, 2024
Address e2e and component tests after moving to the latest PatternFly dropdown Display tooltip for disabled menu toggle page action dropdown
marshmalien
force-pushed
the
keyboard-accessible-dropdown
branch
from
c785e9b to
6567541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-12914
https://issues.redhat.com/browse/AAP-12952
Update to PatternFly's latest implementation of dropdown and remove deprecated implementation. Some breaking changes addressed:
positionas DropdownpopperProps<Tooltip>from dropdown items and pass tooltip properties as DropdownItemtooltipPropschildren<DropdownSeparator>with<Divider>componentprop withto